openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.37k stars 1.21k forks source link

Support for OpenStreetCam detected signs #4851

Open mvexel opened 6 years ago

mvexel commented 6 years ago

OpenStreetCam is rolling out sign detections gradually. An updated JOSM plugin is close to release. It would be great to have iD support this layer as well. Ideally this would work in a similar fashion as the corresponding Mapillary layer.

I will update this ticket once I gather the details about the API. For now, here is an existing OSC trip that has sign detections.

screenshot 2018-03-06 15 09 06

This is not rolled out on all trips yet, but OSC web site and JOSM support just about done, so it would be great to get started on this.

If you are interested in picking this up, I'm here to help.

bhousel commented 6 years ago

This is awesome! great news @mvexel 👍

mvexel commented 6 years ago

Thinking about sign symbol assets -- @bhousel would you prefer to have shared image assets with the Mapillary sign layer? Or can we use the assets we already host for the OSC web site for this layer?

bhousel commented 6 years ago

Thinking about sign symbol assets -- @bhousel would you prefer to have shared image assets with the Mapillary sign layer? Or can we use the assets we already host for the OSC web site for this layer?

I think I'd prefer to keep them separate rather than try to use a shared one..

I have a TODO to switch over the Mapillary sign assets anyway to use this: https://github.com/mapillary/mapillary_sprite_source (see https://github.com/openstreetmap/iD/issues/4145#issuecomment-321809897 )

At least for iD, it's much better to have the assets in SVG instead of the current image sprite.

mvexel commented 6 years ago

I'm looping in my colleagues @alexandrui-telenav and @beataj-telenav who are finalizing the OSC API v2 that includes the detections API.

mvexel commented 6 years ago

Here's the relevant bits of the OSC v2 API docs @bhousel

ApolloServiceAPI.pdf

And the icons

detection-icons.zip

Is this sufficient to run with?

mvexel commented 6 years ago

Any questions about this? I wish I had more help to offer to implement.

bhousel commented 6 years ago

Any questions about this? I wish I had more help to offer to implement.

I took a look through the .pdf, and it seems to contain everything needed - thanks!