openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.37k stars 1.21k forks source link

Better angle field editor for direction tag #5530

Open RudyTheDev opened 5 years ago

RudyTheDev commented 5 years ago

Perhaps a circle you can click next to the field that sets the angle in that direction for you, then adjust further with the arrows as needed. Something like this (although probably on the other side now that I see it):

mockup

bhousel commented 5 years ago

I guess - people can just look on the map though. We show the cone at z18+:

screenshot 2018-11-27 17 02 08
RudyTheDev commented 5 years ago

The cone is awesome and the only reason I even started adding angles/directions for stuff. I guess the issue is you cannot edit it quickly enough or with the mouse/finger (unless it's in increments of 1). You cannot use rotate tool/mode on points. So it's trial and error manually typing it first and then adjusting.

quincylvania commented 5 years ago

How about instead of adding another control to the field we just let people drag the cone to rotate it?

jidanni commented 4 years ago

Here I was wishing I could just grab the tip of that teardrop representing the traffic mirror, and rotate it just right... and click confirm on it. (Currently in fact it indicates 180°.) 12632-0

danieldegroot2 commented 2 years ago

For the current arrow buttons

A 'step' button/dropdown could be added for a higher increase/decrease, i.e. steps of 1, 2, 5, 10.

Perhaps a circle you can click next to the field that sets the angle in that direction for you, then adjust further with the arrows as needed.

Dials as the one above are intuitive, but can be finicky to use. They could still be implemented. Instead of a dial, this could be used:

And, instead of

drag the cone to rotate it

or

grab the tip of that teardrop [...] and rotate it

Make a right click ("Rotate") and hotkey ("R") option, so people don't accidentally rotate the object. For multiple values, tell users to use the slider. Already used by buildings.

Additionally, option(s) may need to support

Option(s) may need to only support values 0 - 360 ( #8206 ). An iD Validator warning could be returned for values

Something similar could be done for incline (several keys), orientation (several keys), roof:angle and related keys (alternative for #6991 ).

This may or may not also concern the rotation of ways, as accurate rotation is usually either not needed or bad -for segments with different angles-. For ways,

For the 'fixed direction' field used on ie. traffic signs,

For traffic signs seperate from ways, allow using the last option above but for an arbitrary way. (similar to a 'parallel way' operation.)

Sidenote This comment does not take into account orthogonal angles to adjacent or seperate ways. ( #9733 / #1957 )

References

Dimitar5555 commented 2 years ago

I've seen a different interface for such selectors which consist of multiple radio buttons which are placed around an image. I'm not sure if it would fit in iD's design though. It can be reworked to be a box of the element in the sidebar (like it's done for turn restrictions) with the current imagery as background. image

danieldegroot2 commented 3 months ago

Related https://github.com/streetcomplete/StreetComplete/issues/2514#issuecomment-812751366 (directions for guideposts)

danieldegroot2 commented 3 months ago

Related https://github.com/streetcomplete/StreetComplete/issues/5765#issuecomment-2261705896 (directions for and distance between objects); May help to correct POI positions, especially with insufficient imagery.