openstreetmap / iD

šŸ†” The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.36k stars 1.21k forks source link

Add branch= to commercial POIs #6585

Closed nicolasmaia closed 5 years ago

nicolasmaia commented 5 years ago

Right now a lot of mappers incorrectly add the branch name to the name field, although we have branch. We should also allow translation of branch names (in a way similar to how the name field is translated), as branch:en, etc.

This would be useful so that a person looking for a school in Tokyo, for instance, will get both the name and branch name in English.

1ec5 commented 5 years ago

There are cases where the branch name does go in name, not just in branch, as in the case of many chain hotels where the branchā€™s name is signposted. This is a difficult distinction to make while keeping the field labels concise.

nicolasmaia commented 5 years ago

Maybe hotels can do without this field. Are there any other commercial establishments we can think of where branch wouldn't apply?

andrewharvey commented 5 years ago

Right now a lot of mappers incorrectly add the branch name to the name field, although we have branch. We should also allow translation of branch names (in a way similar to how the name field is translated), as branch:en, etc.

Who says it's incorrect to add the branch name to the name field? According to the wiki "name=* should then hold only what can be physically observed on signs at the individual branch". In many cases like banks the branch name is also signposted.

Maybe hotels can do without this field. Are there any other commercial establishments we can think of where branch wouldn't apply?

Branch can still apply even if the branch is used in the name.

eg.

shop=mall name=Westfield Hornsby brand=Westfield branch=Hornsby

or

amenity=bank name=ANZ Chatswood branch=Chatswood brand=ANZ

Same for many banks, car dealerships

1ec5 commented 5 years ago

name can include or exclude the branch name on a case-by-case basis, even within a given chain:

In these cases, name ā‰ˆ brand + branch. Maybe to make that relationship clearer, brand and branch could sit on the same line, sort of like in some address field formats.

What would the branch field be called? In American English, ā€œBranch Nameā€ would be understandable for banks, but people donā€™t call individual fast food restaurants or apartment complexes ā€œbranchesā€. Iā€™m not sure of the situation in other languages.

Adamant36 commented 5 years ago

What would the branch field be called?

"location" seems to fit for your examples.

mds08011 commented 5 years ago

Similar to this issue #6561 where the location is added to the name

tohaklim commented 5 years ago

branch is often a case of "ref"

bhousel commented 5 years ago

Right now a lot of mappers incorrectly add the branch name to the name field, although we have branch.

Since it looks like adding this info in the name field is still the recommended practice in a lot of situations, let's not do this.