openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.36k stars 1.21k forks source link

General hierarchy check #6892

Closed jidanni closed 5 years ago

jidanni commented 5 years ago

If one tries to save an isolated road in the middle of nowhere, iD will warn that it is unconnected to the road network.

That's good. But here is another situation iD could warn about too:

19029-1

(Except for the highest grade road in the whole island/continent.)

quincylvania commented 5 years ago

@jidanni Can you provide a link to a location you're seeing this?

I'm not sure this is always an error or something we need to bother iD mappers about, but perhaps I could be convinced.

jidanni commented 5 years ago

(No link because I already hastily fixed that road already.) Perhaps I could be convinced such items are not mistakes: provide one shopping center (campground, etc., even suburb) whose bigger road(s) inside are connected to the outside world by a smaller/poorer road.

I bet even remote "northern" communities have higher grade roads leading to them then their internal streets. (If they are linked to the road grid at all.)

quincylvania commented 5 years ago

@jidanni Yeah even if this warning would be valid it doesn't seem like a common or important issue for OSM right now. I think let's spend our development time elsewhere.

jidanni commented 5 years ago

(Actually, the current check,

Is just a special case of the better check,

And in fact the same concept can be applied to any hierarchy,

Not only for lines and areas, but more generally:

And in fact depending on what part of the world we are in, we can enforce

And in the very rare case one is e.g., actually

One can ignore the warnings.)

quincylvania commented 5 years ago

@jidanni Those are interesting ideas that might be useful for another tool, but again, I don't think this kind of thing is worth bothering iD mappers over right now.

Also, please refrain from changing the scope of issues after they've been closed. It creates confusion and is not an effective way to have an idea considered.