openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.37k stars 1.21k forks source link

Add man_made=windpump to presets #7709

Closed AntMadeira closed 4 years ago

AntMadeira commented 4 years ago

Hi there.

I would like to suggest adding man_made=windpump to iD's presets.

Regards.

Adamant36 commented 4 years ago

Mind if I ask how people know it's a windpump from the satellite images, or even on the ground, instead of just a regular windmill? Because the example image on the wiki just looks like a regular windmill to me. It's even called a "windmill" in the file name. So, I'm thinking the distinction between them isn't that clear, likely most (or all) windpumps are also inherently windmills. Therefore that adopting this tag could lead to a lot of needless miss-tagging and fragmentation. If windpumps are just a type of windmill, then something like windmill:type=windpump should be used instead of having a separate man_made tag for it.

AntMadeira commented 4 years ago

Hi, Adamant36. Well, those are two completely different things. One is a pump and the other is a mill. They not only look different (at least here in Europe), they also have different functions and can clearly be distinguished from satellite images or on the ground, just like so many other features. A windpump is a pump powered by wind and windmill is a mill (used to grind something, usually cereals) powered by wind.

AntMadeira commented 4 years ago

Well, now that I read more about it, I understand your question better. This is an issue to debate on the tagging mail list (I see you posted the same question on the wiki), but here in Portugal, windmill is a windmill, it's never confused with a windpump (especially the kind with those metal blades). I don't really think they even should be called windmills, since they don't grind anything, but that's an etymologic question that it's not relevant here. If you think it worth the try of changing the tag, go ahead and make the proposal on the mailing list, but I was just asking to add a new preset based on what already existed on the wiki.

1ec5 commented 4 years ago

I assume you’re discussing this image:

This is a classic design for an American-style windpump. In the Midwest where I’m from, windpumps are colloquially called windmills, even though they’re unrelated to windmills, because actual windmills are rare (pretty much only at minigolf courses). The person who uploaded the image to Commons was probably unaware of this distinction, but Wikipedia and the OSM Wiki only use it as an illustration of a windpump, not a windmill.

Their function aside, windpumps and windmills differ in much the same way that man_made=mast differs from man_made=tower. Both are colloquially called towers, too, but we still have separate presets for them because one is more structurally substantial than the other.

Windpumps are difficult to spot in aerial imagery because they have such a slender profile, but I’ve been able to spot a few based on the shadows they cast:

OSIP 6in Mapbox (3in)
OSIP 6in Mapbox
quincylvania commented 4 years ago

A good icon should help people distinguish these from windmills. We can add "windmill" as a search term so people will see both and hopefully learn about the distinction. I'd assume windpumps are widely mistagged as windmills in the US.

ghost commented 4 years ago

'aerorotor' is a genericised trademark for the punched steel ones that people sometimes call them by in New Mexico.

quincylvania commented 4 years ago

I made an icon for this that'll be in the next release of temaki. It's tough to keep the blades from blurring at small sizes, but the general shape is there.

Screen Shot 2020-10-19 at 10 24 31 AM
bhousel commented 4 years ago

oh that's a nice icon 🤩