search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.35k stars 1.2k forks source link

"manual imagery" descriptions not translatable #7724

Open manfredbrandl opened 4 years ago

manfredbrandl commented 4 years ago

image image

maro-21 commented 4 years ago

I reported it four months ago in https://github.com/openstreetmap/iD/issues/7358 and it was closed as solved.

manfredbrandl commented 4 years ago

The strings All fields, All tags and All relations are translatable now, so #7358 is solved, but not for the maxar strings. I hope "Somebody" will help here.

quincylvania commented 4 years ago

Turns out the Maxar strings have a different underlying issue from the other strings in #7358. Since they use encrypted endpoints, they're not included in the editor-layer-index and so don't use the standard imagery translation workflow.

manfredbrandl commented 4 years ago

@quincylvania no maxar strings in transifex as you have probably seen and reopened

quincylvania commented 4 years ago

no maxar strings in transifex as you have probably seen and reopened

@manfredbrandl Yep. I mistakenly thought Transifex pulled the strings from en.json, but it actually pulls the imagery and community strings right from their respective projects. This is okay, but it means we'll probably have to include the Maxar strings in core instead of imagery.

Screen Shot 2020-06-24 at 11 50 18 AM
manfredbrandl commented 4 years ago

Including maxar string in core not imagery: not the best but the best available solution so far. very okay for me.

maro-21 commented 4 years ago
quincylvania commented 4 years ago

Why are there two Maxar layers if they have the same imagery? Why are there two Esri layers if they have the same imagery?

@maro-21 They're not the same imagery all over the globe. Both companies maintain two separate endpoints and can independently update the data for any given location at any time.

tyrasd commented 1 year ago

Currently, the Maxar imagery is unavailable for mapping (see #9710), but the issue applies in principle to all sources in data/manual_imagery.json. Currently, these are the two Mapbox layers: Mapbox Satellite and the Locator Overview overlay) Affected are only sources which are not also present in ELI[^1], so currently, no layers are affected by this bug, so a workaround to avoid this issue would be to always add iD's manual imagery also to ELI (excluding any potentially iD specific details like API keys, etc.).

[^1]: The iD project on Transifex is configured to pull the to-be-translated strings for the "imagery" resource directly from the ELI repository. Because of that, iD's build scripts cannot simply "add" the manual imagery to the translation source files.