openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.34k stars 1.2k forks source link

Allow Combining looped ways #7732

Open blackboxlogic opened 4 years ago

blackboxlogic commented 4 years ago

In the situation where a road ends in a turning loop, mapped as separate elements (in a "lollipop" shape), I'd like to be able to select both elements, and use the 'combine' action to turn them into one element.

An example:

There might be a question of which end of the loop should connect to the straight line, I would pick the end which maintains the way's direction. If the straight way is "leaving" the loop, use the loop's end. If the straight way is arriving at the loop, use the loop's start.

The current process for combining elements like this seems to be: split the loop in half, combine each half with the straight part, which seems to work sometimes.

Edit After a another look, I've found that the loop (way/11418145) doesn't have its start/end point where the straight part connects. I see that this makes the issue more technically complicated, and yet, as a user without this knowledge, I know exactly how I would expect it to behave (just combine them). Perhaps there are situations, other than roads, where the start/end point of a loop is significant (maybe like a racetrack?), in which case, it might be incorrect to rotate a loop around itself just to combine it with another element?

image

blackboxlogic commented 4 years ago

A brief discussion found no cases where this would break something.

bhousel commented 4 years ago

A brief discussion found no cases where this would break something.

Combining the loop with the straight part could possibly break a relation with a "via" node at the intersection point, such as a turn restriction, enforcement, or speed camera or something, but this would be pretty rare.

jidanni commented 12 months ago

Yes, wanting to connect "O" + "----------" is very common in the land of driveways that end in flowerbed circles, when one wants to map in detail.

If all this can be done with future added magic, care could be added to assume we want the direction of the circle end to be in the fashion of what way the country drives: US vs. UK etc. Yes, even if we are not intending to later declare it as a one-way street. But still a better than "flip of a coin" choice. (Well, one could say "just draw your circle in the way you want it to run in the first place.")