openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.35k stars 1.2k forks source link

Feature request for user specific flagging using overpass-turbo like queries #7773

Open rjgambrel opened 4 years ago

rjgambrel commented 4 years ago

Use case: I am systematically updating a long highway or extended bike route consisting of many ways, and for each new way (segment) that I touch, I want to be warned in the editor that the way meets certain criteria that I select (such as tiger:reviewed=no). As in overpass-turbo, I would be allowed to type in the query. If the particular way I am now touching some distinctive message or visual indicator would appear informing me that the way meets the criteria.

Value to me: I can systematically walk the extended route and whenever a specific way meets the criteria I specify I am notified and I can address it.

The visual indicator could be something like: the selected item blinks if the criteria is met. Or, a message pops up in the editing window (left pane) that tells me the criteria are met. (Similar to the notifications that I should consider a tunnel or bridge when I am on a way that crosses a river).

I can imagine using many different criteria just as I would in overpass-turbo. I might be interested in criteria for buildings. So ways, areas, points might all have some sort of criteria filter. (Cool if you could allow me to set 3 different criteria). But not neccessary.

Like overpass-turbo allowing a complex query expression with wildcards would be nice too.

For now a simple query for the specific item touched would be simple and adequate.

rjgambrel commented 4 years ago

Bumping this issue. Curious as to why no comments or discussion. Should I just be patient or is this seen as "a bridge to far" or possibly not thought to be very important?

quincylvania commented 4 years ago

@rjgambrel Thanks for your patience. There aren't any paid or full-time developers working on iD right now so it can take awhile to respond to complicated issues.

My initial thought is that this feature sounds too complex for iD. I could theoretically see advanced data selection or map styling based on rich queries, but not anytime soon. I'll leave this open for now so we can think more about it. Does JOSM or another editor have a feature like this?

See also #7388, #6616.

rjgambrel commented 4 years ago

Thank you for the response Quincy. I look at the other referenced requests. I think this could be much simpler, less ambitious, but still useful.

Allow the query to be simple. Doesn't have to be as rich as OT. Main thing is to be able to easily detect and highlight a way (or node, or area) that is being touched. So main capability is for me to be able to specify the criteria (such as highway=residential). If I am touching a way a way which meets the criteria then the way is highlighted (glow, blink, ... ???) OR a message pops up in the left panel that is visible that conveys message that "the criteria are met") Do not need to support lots of wild cards and/or complex logic. Restrict to a single tag, for now, say.

Anyway, glad it is on the list to consider. That is all I can ask. Love the product!!! Oh, and to answer your question: I am not familiar with other editors so don't know if any of them do anything like this.

lectrician1 commented 3 years ago

I am extremely for this. If we could have a way to Overpass query inside of iD and then be able to easily browse through all of the resulting elements, that would make tag cleanup for a variety of projects so much faster.

It's very annoying to use Overpass-turbo right now to get the results for a query and then opening every result in a new tab and then editing them. An example would be my personal experience of removing outdated tags and points with no tags that aren't connected to ways or relations.

Like noted before, TIGER cleanup would majorly benefit from this.

If this was to be implemented, making sure that UI for browsing query results is user-friendly is important. Say, it shows all results in the bbox and then you can use Ctr-ArrowLeft&Ctr-ArrowRight to go result-to-result and iD will zoom to each result you browse. Then, when a result doesn't meet the requirements for the query, it is removed from the list of results. This could work somewhat like how resolving Issues that come up in iD already work.