How does the information button work?

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.

https://www.openstreetmap.org/edit?editor=id

ISC License

3.34k stars 1.2k forks source link

How does the information button work? #7833

Open maro-21 opened 4 years ago

maro-21 commented 4 years ago

I've recently added a Polish Wiki entry for the key beauty=*: https://wiki.openstreetmap.org/wiki/Pl:Key:beauty

As I can see, iD takes the Polish text description iD-information

from https://wiki.openstreetmap.org/wiki/Item:Q2905 For sure, because there is a link to it and this description isn't anywhere else. But why does it link to an English, non-existent, Wiki entry, even though the Polish entry exists?

The link "Przegląd dokumentacji w języku angielskim" directs to https://wiki.openstreetmap.org/wiki/Key:beauty instead of https://wiki.openstreetmap.org/wiki/Pl:Key:beauty. Why? How iD checks existence of a language specific Wiki entry?

sun-geo commented 4 years ago

So far I understand you need to add for https://wiki.openstreetmap.org/wiki/Item:Q2905 the P31 (documentation wiki pages) information "Pl:Key:beauty" first.

You could compare to https://wiki.openstreetmap.org/wiki/Item:Q5056 There you can find that for P31 is "Pl:Tag:shop=beauty" set.

manfredbrandl commented 4 years ago

I think this should be documented in CONTRIBUTING.md in the Translating-Section.

sun-geo commented 4 years ago

Btw, i remember another talk a little bit, see here: #6310 (Potential missing links to wiki documentation pages for several tags)

maro-21 commented 4 years ago

So far I understand you need to add for https://wiki.openstreetmap.org/wiki/Item:Q2905 the P31 (documentation wiki pages) information "Pl:Key:beauty" first.

Oh, I didn't know it should be added there :/ But, yes, it works now, thanks!

maro-21 commented 4 years ago

I think this should be documented in CONTRIBUTING.md in the Translating-Section.

I agree.

suparna-here-123 commented 6 months ago

So far I understand you need to add for https://wiki.openstreetmap.org/wiki/Item:Q2905 the P31 (documentation wiki pages) information "Pl:Key:beauty" first.

You could compare to https://wiki.openstreetmap.org/wiki/Item:Q5056 There you can find that for P31 is "Pl:Tag:shop=beauty" set.

Hello, I am a first-time contributor and would like to add the solution to this issue in the documentation as recommended :) Before I add anything, I would like to ensure the correctness of my understanding of the solution :

According to https://wiki.openstreetmap.org/wiki/Item:Q5056 , 'beauty' should be an instance of (P31) type 'tag' and not 'key'
This P31 value assignment must be made 'tag' for all languages other than English so that they don't lead to the default English mappings. Please confirm/correct my understanding to help me make my very first open-source contribution!

maro-21 commented 6 months ago

Re suparna-here-123: No. From my question in the first post, this issue has turned into a task that information should be added to the documentation.

On the Wiki, everything is in order.

So what we need to do is to complete CONTRIBUTING.md with information:

In order for a description to show up in a particular language when you click the "i" icon, there must be a description on the corresponding data item to this key or tag. If a description in a particular language does not exist, English description is displayed by default.

In order for a link to an article about a particular key or tag in a particular language to show up when you click the "i" icon, there must be a link to that article in the data item in the property P31.

More or less something like this.