openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.35k stars 1.2k forks source link

highway=elevator showing "big street" warning instead of "disconnected" #8018

Closed carstenhag closed 4 years ago

carstenhag commented 4 years ago

So while reporting this, I have found #6812, which likely introduced the "Elevator is disconnected" warning.

Just added a point, added highway=elevator and then I got a "Größere Straßen..." warning. Maybe it's due to highway=elevator not being translated to german? "Größere Straßen" is definitely wrong :D

Related, maybe that's also the reason I could not find "Aufzug" via the point search.

Bildschirmfoto 2020-09-24 um 08 08 21

carstenhag commented 4 years ago

After connecting a line to it, it now shows "Aufzug". Weird.

Bildschirmfoto 2020-09-24 um 08 15 14

quincylvania commented 4 years ago

Oh yeah, this happens because preset matching is dependent on the geometry. Since iD only matches nodes with highway=elevator to the Elevator preset if they're part of ways, and since the names in the validation messages are based on preset names, the fallback name is shown here.

In this case iD knows that the node should probably be part of a way, so we can show the preset name instead.

Here's what this looks like in English for anyone interested:

Screen Shot 2020-09-24 at 8 13 55 AM

carstenhag commented 4 years ago

Thanks for the quick fix :)

quincylvania commented 4 years ago

@carstenhag I'm still not sure why the translation of "Highway Feature" would be "Big Street…" in any language but I'll leave that up to the translators.

sun-geo commented 4 years ago

"Highway Feature" would be "Big Street…"

@carstenhag see here

image

carstenhag commented 4 years ago

Thank you. Yeah, that translation is not good :D. I can see why the person translated it that way, because a highway is of course a big street usually, but in OSM terms a highway can be a footway of course.

I just changed it to "Straßen/Wege..." which means streets and paths. The "..." were used at other preset names as well, so I kept them.