search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.38k stars 1.21k forks source link

Validator shows lots of "too close to" warnings for Stolpersteine #8419

Closed dreua closed 1 year ago

dreua commented 3 years ago

According to the Stolpersteine wiki page (german only) each Stolperstein should be mapped as a single node, even when they are very close to each other.

Example: https://www.openstreetmap.org/edit#map=23/52.18570/9.08078

If you move around the city and select streets with adjacent Stolpersteine the issue list easily gets filled drowning the other real issues.

Fix: Disable those warnings for memorial:type=stolperstein. Code pointers welcome!

Workaround: Maybe I should just consider this a digital "Stolperstein" and live with it?

Find Stolpersteine on Overpass-Turbo

OT: Thanks for developing iD, it's a really great tool and I use it a lot! OSM + OSS = :heart:

dreua commented 3 years ago

Code is probably here: https://github.com/openstreetmap/iD/blob/develop/modules/validations/close_nodes.js

Can we just filter for memorial:type=stolpersteine and memorial=stolpersteine here?

k-yle commented 1 year ago

This was fixed in #9089 and released over a year ago, so I think we can close this issue?

dreua commented 1 year ago

Yes of course, thanks for fixing!