openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.34k stars 1.2k forks source link

Better support with loop please #8435

Open cicku opened 3 years ago

cicku commented 3 years ago

image

My intention is to circularize the roundabout (some nodes are shared with boundary), I don't want to mess with the relation. In iD, I can only accomplish by:

  1. Disconnect shared nodes with boundary (creating a new node, delete a small part of the segment, reconnect with boundary layer off);
  2. Remove all relations used by roundabout segments (bus routes, state route ref, cycle routes);
  3. Delete different names of the segments so I can merge them as a loop;
  4. Merge them as a loop;
  5. Circularize it;
  6. Split segments;
  7. Add names back;
  8. Add relations back

I've had enough with this. If people don't handle relations carefully, these segments will only be worse.

1ec5 commented 3 years ago

This looks like a duplicate of #2048. A simpler workaround would be to carefully draw an area that connects to all the nodes of the existing roundabout ways, circularize that area, then delete it.

jjiglesiasg commented 3 years ago

If the inbound and outbound ways to a roundabout share the same node, Navigators could Not identify the exit number, in this case if you came from the east to the roundabout the navigators infers that the first exit will be the one at the west side of the roundabout and not the Residential road that goes north...

cicku commented 3 years ago

There is no need to identify the exit number in this case. You can discern an "almost separate" right turn lane marked on the ground.

My only concern is the voice TTS engine, if the audio is based on the turn angle, it will not work well. However if the map is depicted by cutting a small segment as suggested, I wish to hear "turn right" instead of "turn right at the first exit" which sounds like kindergarten, so a voice override is needed to make it perfect.

For a standard roundabout like the image above, routers should be smart enough to detect nodes for inbound and outbound and then override the TTS like "at the roundabout going straight" or "at the roundabout make a u-turn". Although it sounds weird for those student drivers, it is still better than "at the roundabout turn right at the fourth exit".

1ec5 commented 3 years ago

This is getting quite off-topic for an iD issue tracker, but this issue is likely a duplicate anyways. So for what it’s worth: the configuration depicted above does interfere with routing guidance. A router traverses a graph of edges, but there’s no edge between the Old Philadelphia Rd. roundabout entrance and the residential exit. A router would need to synthesize an edge to even know that a roundabout is part of the equation.

There might be a kludgy workaround in the form of “rewriting” the roundabout tag onto each of the nodes that form the roundabout way(s) and then rewriting a “roundabout_adjacent” tag onto the entrance/exit ways, but I don’t know how feasible that would be in practice.

For a standard roundabout like the image above, routers should be smart enough to detect nodes for inbound and outbound and then override the TTS like "at the roundabout going straight" or "at the roundabout make a u-turn".

In the U.S. specifically, modern roundabouts are almost always designed and signposted so that each outlet corresponds to a turn lane direction (right/straight/left/U-turn). Your suggestion would be a valuable usability improvement; consider raising the suggestion in the issue trackers for Valhalla, OSRM, Graphhopper, etc. However, exit counting is the norm in other countries, so it would be a country-specific guidance heuristic. Moreover, a router would still need to know that a roundabout is involved in the maneuver in order to know it should say “Turn right at the roundabout.” As things stand, some routers will say “Continue straight onto [residential street]” based on the negligible turn angle, while others won’t even produce an instruction for continuing straight.

cicku commented 3 years ago

image