search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.36k stars 1.21k forks source link

Add priority=* field to traffic_calming=choker #8505

Open boothym opened 3 years ago

boothym commented 3 years ago

The preset currently has a direction=* field - which seems a bit redundant as a choker affects both directions by definition.

Having a field for the priority=* tag instead would be better, especially if there was a way to visually indicate which direction has priority.

tordans commented 3 years ago

JFYI, tagging topics are managed at https://github.com/openstreetmap/id-tagging-schema/issues nowadays. Once this project is actively maintained again, I think this issue will be moved there (moving issues is IMO better than creating a duplicate).

The way I understand you suggestion is, to replace direction with priority, which would be deprecating direction in favor of priority. Ideally with an "outdated tag" suggestion in iD.

Personally, I think this is a valid point. I used direction in the sense that priority is defined today. And I think that was the intend why it was added in 2016 (link below).

It would also allow to add deprecations / tag-update-alerts for the alternative tagging schema of

Some more research:

Some images for reference:

tordans commented 3 years ago

Update to my last comment: We talked about this in a OSM Community Meetup in Berlin.

I am not so sure about this change now. Here is why:

The priority key is described as something that is signed with a sign (https://wiki.openstreetmap.org/wiki/Key:priority). That is not the case for most choker we have inside the city of Berlin.

If we migrated direction to priority, we would change this implicit information. Right now, we can assume that a node with priority also has a sign. But we cannot do the same for direction.

This leads to more thinks to consider:

The sign could say "right lane may drive first" but the choker could be on either the right or the left. There are probably rules per country which direction should go first … and a few exceptions from this rule.

The local rules that translate priority to the position of the choker (given only one side has it), is probably different per country (especially countries that primarily use the left/right lane). So there is no easy path to migrate from the old to the new.

Considering those topic, I think direction is a fine. It give a clear information about the layout of the street and leaves it to the router to know the local rules. And a mapper could always add the priority or (IMO even better) traffic_sign key for additional information.

boothym commented 2 years ago

Perhaps this is better illustrated with an example of a choker in Scotland/UK: https://www.mapillary.com/app/?pKey=290824359298218

In this case the node would be tagged as priority=forward, following the direction of the way of course.

What should the direction tag value be? Because the "choking" applies to both directions of traffic, adding this tag doesn't seem right to me (or at least, it is redundant).

As for chokers in Berlin without any priority - wouldn't the tag just not be used in that case?