openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.38k stars 1.21k forks source link

Add validator rules to discourage abbreviations in street names #8795

Open tyrasd opened 3 years ago

tyrasd commented 3 years ago

This would show a information bus if a highway feature is mapped with a name which includes a commonly used abbreviation, such as the St in "Cedar St". This would need to be localized, since other countries other abbreviations would typically be found (e.g. …str. in German speaking regions or V. … in Italy). In multilingual regions, the corresponding name:<xy> tags would need to be checked too.

(Idea sourced from https://www.openstreetmap.org/user/Glassman/diary/395633.)

cliffordsnow commented 3 years ago

I have sql statements with typical abbreviations expanded. See https://github.com/cliffordsnow/sql. It's not complete but does cover every abbreviation I see in the US Pacific Northwest. Another one at https://github.com/baltimorecounty/openstreetmap/blob/master/create_osm_view_pubsafe.sql

1ec5 commented 3 years ago

Some additional nuances to consider:

These considerations wouldn’t necessarily be showstoppers, but the validator warning would ideally be gentle enough that mappers wouldn’t feel compelled to “fix” a nonissue.

cliffordsnow commented 3 years ago

My original intent was only the abbreviation of street names, not businesses or places. Infact, business names should be exactly as how they are signed.

But street name abbreviations is one of the bigger issues with new mappers in the US. A country specific validation would be ideal. There will always be difficult cases. as @1ec5 mentioned, Author St. Clair. Those are in the minority. We could catch may street name (ways) errors with a validator warning.

AntMadeira commented 3 years ago

This would be a nice addition to the validator. Abbreviated street names are a problem also in Latin countries, where many words are abbreviated with a "." Like S. or D. or Dr.

matkoniecz commented 3 years ago

In case of collecting abbreviations it would be really useful to setup separate project (or put it into id-tagging-schema?) which could be reused by other editors.

See https://github.com/streetcomplete/StreetComplete/blob/bb71ae91976ce4f16c22c7ce09ecdcc388a649e1/app/src/main/res/raw/abbreviations.yml https://github.com/streetcomplete/StreetComplete/blob/bb71ae91976ce4f16c22c7ce09ecdcc388a649e1/app/src/main/res/raw-fi/abbreviations.yml https://github.com/streetcomplete/StreetComplete/blob/bb71ae91976ce4f16c22c7ce09ecdcc388a649e1/app/src/main/res/raw-pl/abbreviations.yml in StreetComplete, it would be sad to duplicate this work.

Pinging @westnordost

LOVElife420 commented 3 years ago

Unsubscribe

On Sat, Nov 13, 2021, 5:13 PM Mateusz Konieczny @.***> wrote:

In case of collecting abbreviations it would be really useful to setup separate project (or put it into id-tagging-schema?) which could be reused by other editors.

See https://github.com/streetcomplete/StreetComplete/blob/bb71ae91976ce4f16c22c7ce09ecdcc388a649e1/app/src/main/res/raw/abbreviations.yml https://github.com/streetcomplete/StreetComplete/blob/bb71ae91976ce4f16c22c7ce09ecdcc388a649e1/app/src/main/res/raw-fi/abbreviations.yml https://github.com/streetcomplete/StreetComplete/blob/bb71ae91976ce4f16c22c7ce09ecdcc388a649e1/app/src/main/res/raw-pl/abbreviations.yml in StreetComplete, it would be sad to duplicate this work.

Pinging @westnordost https://github.com/westnordost

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openstreetmap/iD/issues/8795#issuecomment-968169833, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWLYWFZCXHWQKWBJYECFLYLUL3WJVANCNFSM5HTHCB7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

matkoniecz commented 3 years ago

@LOVElife420 That just published it as a comment not unsubscribed. And notified everyone else. You can unwatch iD repository at https://github.com/openstreetmap/iD or use unsubscribe link in footer of the email.