search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.29k stars 1.19k forks source link

Organize Backgrounds list by category #8814

Open jidanni opened 2 years ago

jidanni commented 2 years ago

Description

Currently we see:

Backgrounds

Better would be:

Backgrounds

1ec5 commented 2 years ago

The suggested organization would require osmlab/editor-layer-index#136.

jidanni commented 2 years ago

For now please move CyclOSM down to my suggested position.

1ec5 commented 2 years ago

iD doesn’t special-case specific layers to put them in specific locations, other than None and Custom (which are built-in options rather than layers loaded from ELI).

jidanni commented 2 years ago

Looking at where the alphabet breaks order, I detect three groups above. Hmm, so apparently CyclOSM needs to be renamed O-CyclOSM through Z-CyclOSM, as a hack, to get it to group properly with the non-image layers!

1ec5 commented 2 years ago

Oh huh, I never noticed that it does the same in the U.S. with “National Agricultural Imagery Program” appearing between “Stamen Terrain” and “U.S. Forest Service roads”. Looks like it’s actually sorted first in descending order by coverage area, then in ascending order by name:

https://github.com/openstreetmap/iD/blob/e2a5345c7fa8f6555b4c2b22d14a4f4eca717bbc/modules/ui/sections/background_list.js#L171-L175

It’s a bit unfortunate that the first sort is in descending order, because it shifts the local sources down to where users are less likely to notice them. I guess the expectation is that good local sources are already marked as best in ELI, but that’s a tricky decision because “best” can mean many things: osmlab/editor-layer-index#130.

jidanni commented 2 years ago

Also

So maybe they should be real low in the list.

todrobbins commented 2 years ago

I like the idea of grouping the available layers in types (map renderings, remote sensing/imagery), and maybe even allow for the list to be rearranged by drag+drop to your preference. 🤷🏻‍♂️

jidanni commented 2 years ago

I actually was thinking of giving titles to each of the groups I made within the horizontal bars: Imagery, Maps, Local sources, etc.

tyrasd commented 2 years ago

I think as a start, we could at least sort by the imagery's ELI category which would be osmbasedmap for cyclosm for example.

1ec5 commented 2 years ago

Cool, I hadn’t realized osmlab/editor-layer-index#733 introduced a category system. I guess osmlab/editor-layer-index#136 is just tracking a follow-on discussion about a specific categorization issue.

boothym commented 2 years ago

Just to say that I agree with this - I've misclicked on CyclOSM a number of times since it was moved to 2nd in the list!

I made a similar suggestion years ago when the layers more than 20 years old were removed from iD, of having a dropdown where for example historic layers could be hidden rather than removed altogether.

https://github.com/openstreetmap/iD/issues/3453#issuecomment-258199010

endolith commented 1 year ago

Yes, please put all the satellite maps together