openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.35k stars 1.2k forks source link

Strava Heatmap #9129

Open jjiglesiasg opened 2 years ago

jjiglesiasg commented 2 years ago

Description

Is feasible to have a better integration of the Strava heatmap into ID. Where I live there is very few GPS traces in the database, but seems to be a lot of Strava Heatmap activity. I am also Strava account user.

Please review and consider

BsRgds

JJ

Screenshots

None

Georift commented 2 years ago

If I remember correctly the reason something like this couldn't be packaged by default is that the Strava API requires a user account to be provided.

There is a guide for how to add this to iD detailed here

Georift commented 2 years ago

Do you have any ideas for how iD might serve Strava users better?

jjiglesiasg commented 2 years ago

In this case is otherwise, the idea is to Strava heatmaps serve ID/JOSM users. They already use our map, time to give back in exchange. Their Heatmap seems to be better in most cases, than the GPS traces, at least in cities and sorroundings for road aligment, I guess if this could be integrated as a background layer, without all these process described in this link:

https://erickdeoliveiraleal.medium.com/tutorial-strava-openstreetmap-josm-or-id-2e2003f4aea3

Just serious mappers use this data, because basically is NOT available to regular users

jjiglesiasg commented 2 years ago

indeed, the "new" method Do not allow you to copy the strava link in the ID "Custom Map Data", but in Strava give you the options to open JOSM or ID, however if you open ID using the shortcut, it dosen't open the same area that you are "seeing" in the Heatmap in Strava but to a previous location stored in ID. Screenshot 2022-05-27 23 53 42 Screenshot 2022-05-27 23 53 19 Screenshot 2022-05-27 23 53 14

DujaOSM commented 2 years ago

If I remember correctly the reason something like this couldn't be packaged by default is that the Strava API requires a user account to be provided.

Freemaps.sk (based on OSM) does not seem to have a problem with that: https://www.freemap.sk/?map=13/45.245102/19.843884&layers=Zs0

Adamant36 commented 2 years ago

If I remember correctly the reason something like this couldn't be packaged by default is that the Strava API requires a user account to be provided.

I don't think they ever got definitive permission to use the heat map. If I remember correctly an employee from Strava said in an email that it was OK to use it, but some people didn't think that was good enough. There's a couple of mailing list discussions about it and it's also briefly mentioned in #4896. Along with https://github.com/openstreetmap/iD/issues/3150#issuecomment-224246160 in #3150 and several other places. The TDLR of it is that there's zero chance of Strava heatmaps being usable in iD Editor anytime soon, if ever.

jjiglesiasg commented 2 years ago

So basically they get their map from us for free, we get NOTHING from them. Excellent Deal...

On Sat, Jun 4, 2022 at 11:19 PM Adamant36 @.***> wrote:

If I remember correctly the reason something like this couldn't be packaged by default is that the Strava API requires a user account to be provided.

I don't think they ever got definitive permission to use the heat map. If I remember correctly an employee from Strava said in an email that it was OK to use it, but some people didn't think that was good enough. There's a couple of mailing list discussions about it and it's also briefly mentioned in #4896 https://github.com/openstreetmap/iD/issues/4896. Along with #3150 (comment) https://github.com/openstreetmap/iD/issues/3150#issuecomment-224246160 in #3150 https://github.com/openstreetmap/iD/issues/3150 and several other places. The TDLR of it is that there's zero chance of Strava heatmaps being usable in iD Editor anytime soon, if ever.

— Reply to this email directly, view it on GitHub https://github.com/openstreetmap/iD/issues/9129#issuecomment-1146732775, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOKQKSTEL4OTCMP37LLYE3VNQMFNANCNFSM5W2V7HKA . You are receiving this because you authored the thread.Message ID: @.***>

-- Juan Jose Iglesias Technical Field Representative Ph/Wa: +591 72213368 Skype: jjiglesiasg

Adamant36 commented 2 years ago

So basically they get their map from us for free, we get NOTHING from them.

Yep. That's literally how open source free software works :man_facepalming:

boothym commented 2 years ago

The best thing that iD could do is to support the use of the heatmap is allow the custom layer to function as an overlay (like JOSM) so that aerial imagery can be seen instead of the black background you get from using the following layer.

https://proxy.nakarte.me/https/heatmap-external-b.strava.com/tiles-auth/all/hot/{zoom}/{x}/{y}.png?px=256

According to https://wiki.openstreetmap.org/wiki/Strava#Data_Permission_-_Allowed_for_tracing! we have permission to use the heatmap in OSM.

Adamant36 commented 2 years ago

We have permission to use the heatmap in OSM.

From what I remember the "permission" wasn't legally binding. A product manager of a product can say whatever they want in a private email to a costumer, but that's extremely different then a legally binding license to use the heat map, which I assume is what iD Editor would need for it to use the map. I think that's clear in the fact that Mr. Davies says "you" can continuing the heat map. "You" doesn't mean he talked to his legal team and they gave the OSM community as a whole, writ large, carte blanche legal rights to the heat map.

jjiglesiasg commented 2 years ago

That's not the Duty of OSMF to get those "permits"?, like we granted licenses to them, they could grant to us. Qui-Pro-Quo

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free. www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Wed, Jun 8, 2022 at 4:10 PM Adamant36 @.***> wrote:

We have permission to use the heatmap in OSM.

From what I remember the "permission" wasn't legally binding. A product manager of a product can say whatever they want in a private email to a costumer, but that's extremely different then a legally binding license to use the heat map, which I assume is what iD Editor would need for it to use the map. I think that's clear in the fact that Mr. Davies says "you" can continuing the heat map. "You" doesn't mean he talked to his legal team and they gave the OSM community as a whole, writ large, carte blanche legal rights to the heat map.

— Reply to this email directly, view it on GitHub https://github.com/openstreetmap/iD/issues/9129#issuecomment-1150356306, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOKQKWUIB366PPNU6YTCS3VOD43RANCNFSM5W2V7HKA . You are receiving this because you authored the thread.Message ID: @.***>

-- Juan Jose Iglesias Technical Field Representative Ph/Wa: +591 72213368 Skype: jjiglesiasg

tordans commented 2 years ago

One way forward would IMO be, to start a second try to get an official legal permission from Strava.

And within that process, to setup a technical setup that would allow editors to ask and receive for a api access key that is unique to the editor (not the user). The second part is already done for Bing areal images (it was Bing, right?).

For the whole setup, my take would be: Prepare a letter that the OSMF formally sends to Strava. Coordinate the process via OSMF but help the board with the writing and coordination.

This way, the request would IMO become official enough to be integrated into the strava corporate processes to create a clear result. (Which could still be a 'no', but an official 'no' is something we can work with…)

jjiglesiasg commented 2 years ago

I do agree, that the process needs to be formal, and driven by the OSMF.

BsRgds

User: JJIglesias

El jue., 9 jun. 2022 02:32, Tobias @.***> escribió:

One way forward would IMO be, to start a second try to get an official legal permission from Strava.

And within that process, to setup a technical setup that would allow editors to ask and receive for a api access key that is unique to the editor (not the user). The second part is already done for Bing areal images (it was Bing, right?).

For the whole setup, my take would be: Prepare a letter that the OSMF formally sends to Strava. Coordinate the process via OSMF but help the board with the writing and coordination.

This way, the request would IMO become official enough to be integrated into the strava corporate processes to create a clear result. (Which could still be a 'no', but an official 'no' is something we can work with…)

— Reply to this email directly, view it on GitHub https://github.com/openstreetmap/iD/issues/9129#issuecomment-1150726312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOKQKTUH76IZLSITAG6KRDVOGFY5ANCNFSM5W2V7HKA . You are receiving this because you authored the thread.Message ID: @.***>

1ec5 commented 1 year ago

https://github.com/zekefarwell/josm-strava-heatmap#manually-adding-the-imagery-in-id

cmoffroad commented 1 year ago

The legal aspect has already been discussed and answered in this thread: https://community.openstreetmap.org/t/strava-mapping-legal-usage/

One limitation of iD is the lack of a custom Overlay URL mechanism, which restricts the visibility of the heatmap to a background layer only.

To address this limitation and provide more functionality, I have developed and published a Strava Heatmap extension for iD. You can find more information about it here: https://community.openstreetmap.org/t/new-strava-heatmap-extension-for-id/

cmoffroad commented 1 year ago

Freemaps.sk (based on OSM) does not seem to have a problem with that:

Unless they have a specific agreement with Strava, It's highly likely that Freemaps.sdk exposes its own Strava user's account cookie credentials and manually updates them when they expire. If this is the case, it may violate the user terms and conditions.

From what I can gather, iD does not have a built-in capability to integrate with Strava due to the fact that the only way to obtain the user's Strava cookies credentials is through a browser extension.