openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.37k stars 1.21k forks source link

Index imagery for Maxar #9147

Closed Mahabarata closed 1 year ago

Mahabarata commented 2 years ago

Description

Hi,

in transifex, we have almost all the imageries (name and description) but not Maxar Premium Imagery : could you add it ?

I had open an issue on editor-layer-index #1451 but it seems it is not the good place, I hope it is the good one here.

Best regards

Screenshots

see this capture Capture d’écran 2022-03-12 125237

The first line is not in polish or english but in french because in transifex you have added the original text so we can translate it. Same thing for the 2d, 3rd, 4th, 6th, 7th, 8th... in fact all the lines are not the original ones but a translation.

Except the line 5 (Maxar Premium Imagery) : the text is the original because the text is not in transifex so impossible to translate it.

Same thing with the texts under the mouse :

My asking is to be able to translate the 3 texts about Maxar (name, description and attribution) like for all other lines.

1ec5 commented 1 year ago

The string is currently hardcoded here:

https://github.com/openstreetmap/iD/blob/5f92841a8ee5bb371a7f3898725493a97aa5adca/data/manual_imagery.json#L4

This code looks like it tries to make the string localizable through Transifex:

https://github.com/openstreetmap/iD/blob/a15f6ff338dd7b1a1e64b90574afba0d67be96ce/scripts/build_data.js#L218

Not sure why it isn’t being exposed in the UI.

Mahabarata commented 1 year ago

When I look at the line 236 in the build_data, the result of the writeEnJson function is written in the file en.min.json.

But in the directory iD/dist/locales, the file is not present so I cannot look at it to see if imagery.Maxar is present (probably not).

Where is this file ?

tyrasd commented 1 year ago

This is duplicate of #7724.