openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.34k stars 1.2k forks source link

Feature Request: Mark as covered. #9290

Open EvanCarroll opened 2 years ago

EvanCarroll commented 2 years ago

Description

This is very annoying for me.

Screenshot_2022-09-11_11-06-08

This is caused by placing sidewalks, or drive through under roofs or carports.

s

What you have to do currently is break the sidewalk, and mark the part under as "covered=yes"

solved

This "mark as covered" on footpaths and sidewalks and drive-through, and driveways would make it such that, for my workload, ALL manual intervention could be one-click.

EvanCarroll commented 2 years ago

I think too you can make the argument that this isn't just convince but more correct. The layer documentation says this,

With some exceptions, layer= on way ways should be used only in combination with one of tunnel=, bridge=, highway=steps, highway=elevator, covered= or indoor=yes. For area areas, it could be used in combination with tags such as man_made=bridge, special types of building=* and similar.

So the thing made easy, currently, is to tag the car port as layer=1, which then allows you to save. But that's likely not correct unless it is an "exception". The general rule seems to be use covered=yes, at the least. Potentially in combination with a layer.

But it also seems like allowing layer=1 on a building is generally not a good idea, also a quote from the wiki,

special types of building=* and similar. [...] *Ways in buildings (or similar structures like multi-level parking lots, shopping centers, airports, railway stations, some multi-level bridges and roads...) should be mostly described with level= instead of layer.**

I think as a general rule, you should not have a layer=1 to put a road under a regular mundane building, carport, or roof. Though easy with iD, this seems to be lacking in correctness.

1ec5 commented 2 years ago

The bit about level refers to hallways (highway=corridor), parking lot aisles inside a parking garage, etc., as opposed to roads that happen to go under a canopy. Note that the Roof preset also adds layer=1.

EvanCarroll commented 2 years ago

Ok, so it sounds like we need to figure out whether or not what is being done is advisable,