search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.38k stars 1.22k forks source link

convert non-standard dashes to standard dashes in the Opening Hours field #9735

Open RedAuburn opened 1 year ago

RedAuburn commented 1 year ago

URL

https://www.openstreetmap.org/changeset/138191928

How to reproduce the issue?

Upload opening hours using a non-standard dash

the standard dash seems to be - (Hyphen-Minus) other similar dashes: ‐ HYPHEN ‑ NON-BREAKING HYPHEN ‒ FIGURE DASH – EN DASH ﹘SMALL EM DASH ۔‎ ARABIC FULL STOP ⁃ HYPHEN BULLET ˗ MODIFIER LETTER MINUS SIGN − MINUS SIGN ➖ HEAVY MINUS SIGN Ⲻ COPTIC CAPITAL LETTER DIALECT-P NI (similar characters found from https://www.unicode.org/Public/security/15.0.0/confusables.txt, there may be more)

this leads to parsing fails in some applications, eg. also see https://github.com/organicmaps/organicmaps/issues/3888. it should also be handled at the application level, but it's good to have standard data as well.

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

No response

1ec5 commented 1 year ago

This should be possible to do without introducing a full-fledged parser for the opening hours syntax, which would be part of #974. Note that we probably shouldn’t be messing with anything inside "comments".