openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.37k stars 1.21k forks source link

opening hours form field #974

Open ansis opened 11 years ago

ansis commented 11 years ago

http://wiki.openstreetmap.org/wiki/Key:opening_hours

1ec5 commented 1 year ago

Thanks for taking the time to make this mockup. I’m not the official maintainer, but perhaps I could elaborate on my contrarian comments so far.

Many of the mockups so far are optimized for the simple kind of opening hours that has a single timespan each day of the week, consistent across all weeks of all years. I agree that this is one of the most important cases to address (with varying levels of importance depending on the POI type and region). It’s fair to start with the most important cases and figure out how to shoehorn edge cases into the UI later. Your proposal would actually make #9678 completely unnecessary, because it covers the same exact cases.

However, I think most users who need to use this field are copying opening hours from a sign or website or maybe from memory. These opening hours are always expressed as literal times, so that’s what the user would be able to enter most readily. Any UI that requires dragging, whether on a calendar or a slider, introduces a degree of imprecision. Now you have to watch the time indicator while you drag the slider around. If the shop opens at a quarter past the hour, you’ll need good hand-eye coordination. Where I come from, many schools open or close at five or eight minutes past the hour for some reason.

Pairing each double-knobbed slider with two editable text fields would allow the user to adjust the value to match the sign. But at that point, I wonder if the slider is providing any value compared to just the two text fields (perhaps with dropdown menus or increment/decrement buttons). https://github.com/openstreetmap/iD/issues/974#issuecomment-436405783 has an example of what a text field–based design could look like.

There’s still the issue of minimizing the field’s vertical space. Maybe the field could start out in its current form, as a single unstructured text field, but when you focus the field, a more structured form could slide out below. This wouldn’t quite prevent the user from ever seeing the raw opening hours syntax, but at least it would get the main editing case out of the way so we can focus on a more comprehensive solution.

wcedmisten commented 1 year ago

Yeah that makes sense, now that I think about it, the sliders seem a bit fiddly for entering hours, even if limited to 1-hour intervals.

With https://github.com/openstreetmap/iD/issues/974#issuecomment-436405783, does "add hours" open a separate block to enter other days? Otherwise, how would the user enter e.g. separate weekend hours with that interface?

Or is that not supported in that UI?

1ec5 commented 1 year ago

I assume that screenshot was from the Google Maps UI for suggesting changes. These days, the UI takes up a lot more space; it’s more like a wizard than an inspector now. Clicking “Add hours” lets you add another time span for the selected day or days.

Hours Edit all hours

LySioS commented 3 months ago

It's been 11 years now.

This basic need is still being ignored...

Can we solved it ? @tyrasd