search

openstreetmap / iD

🆔 The easy-to-use OpenStreetMap editor in JavaScript.
https://www.openstreetmap.org/edit?editor=id
ISC License
3.35k stars 1.2k forks source link

Stop showing discardable keys like created_by #9854

Open matkoniecz opened 1 year ago

matkoniecz commented 1 year ago

URL

https://www.openstreetmap.org/edit?editor=id&node=289136538#map=19/50.04234/20.04962

How to reproduce the issue?

See https://www.openstreetmap.org/edit?editor=id&node=289136538#map=19/50.04234/20.04962

Or http://overpass-turbo.eu/s/1z5O for more test cases

Screenshot(s) or anything else?

triggered by https://community.openstreetmap.org/t/polska-propozycja-automatycznego-usuniecia-klucza-created-by/102601/4 (which proposed bot edit to mass remove created_by after noticing it in iD)

screen03

Note that JOSM is hiding it from user and not showing at all.

From https://github.com/openstreetmap/iD/issues/7338 it seems that iD is displaying it and removing on saving.

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

Firefox 116.0.2 (64-bit)

AnitaMari commented 1 year ago

Hi! I want to try to fix the issue. It's the first time I'm contributing to an open-source project, so I hope to be able to fix it and to really contribute in something. And to know how to do it.

Just to clarify, what I need to do is to remove "created_by JOSM" that appears in the edit feature?

screenshot1

tordans commented 1 year ago

@AnitaMari I don't think there is agreement on how to best solve this issue, yet.

On way to solve this would be to add created_by to this file https://github.com/openstreetmap/id-tagging-schema/blob/main/data/deprecated.json which would trigger an update dialogue to remove the key.

IMO the "Tags" section should always show all tags. So in case you where planning to hide it in this UI, I don't think that would be a good solution.

Update: The deprecation was done already https://github.com/openstreetmap/iD/issues/7338. And it is in line with what the wiki says https://wiki.openstreetmap.org/wiki/Key:created_by So I wonder what this issue is actually about…

tordans commented 1 year ago

@tyrasd I now see the "good first issue" label. I think it would be better if all issues that receive this label also get a short comment on how you think this should be solved. (I am aware that some implementation issues will only come up once the work starts, but a general idea on how you would start working on it would still be helpful IMO.)

AnitaMari commented 1 year ago

Thank you! I think I didn't choose a "good first issue" to start my journey in the open-source contribution world. I think I'll look for another one to try to understand how everything works before trying to solve something more complex for me to understand.

El dom, 24 sept 2023 a las 12:10, Tobias @.***>) escribiĂł:

@tyrasd https://github.com/tyrasd I now see the "good first issue https://github.com/openstreetmap/iD/labels/good%20first%20issue" label. I think it would be better if all issues that receive this label also get a short comment on how you think this should be solved. (I am aware that some implementation issues will only come up once the work starts, but a general idea on how you would start working on it would still be helpful IMO.)

— Reply to this email directly, view it on GitHub https://github.com/openstreetmap/iD/issues/9854#issuecomment-1732537254, or unsubscribe https://github.com/notifications/unsubscribe-auth/A33MH2DQK7NGBO6C7SFYHBDX4ABJ7ANCNFSM6AAAAAA3VDJ2LQ . You are receiving this because you were mentioned.Message ID: @.***>

matkoniecz commented 1 year ago

The deprecation was done already https://github.com/openstreetmap/iD/issues/7338. And it is in line with what the wiki says https://wiki.openstreetmap.org/wiki/Key:created_by So I wonder what this issue is actually about…

See https://wiki.openstreetmap.org/wiki/Discardable_tags

To be more specific created_by tags will be silently and automatically removed by iD if their objects were edited. See https://www.openstreetmap.org/node/269485010/history

Note that I have only moved the node, never edited tags and tag was dropped by iD.

JOSM id doing the same for discardable tags, but it is also not showing them on tag list

Adarsh-Dhar commented 10 months ago

Hey its my first time contributing to open source. I want to contribute to this issue can you tell me what do you want instead of created_by

1ec5 commented 10 months ago

Even if the tags are removed upon editing the feature, are we sure it’s a good idea to not even show them in the raw tag editor, as if they never existed? If the user decides not to edit the feature, this might cause them to be confused about whether they removed the tags. Graying out the fields might be less confusing – along with adding a tooltip explaining why.

matkoniecz commented 10 months ago

If the user decides not to edit the feature

in such case tags will not be autoremoved

matkoniecz commented 10 months ago

In fact, if tags are shown during editing and then deleted automatically with no user interaction then it is more confusing for user

Adarsh-Dhar commented 10 months ago

So do you want to remove the tag?

matkoniecz commented 10 months ago

this tags are already being automatically removed on edit

what I proposed here is to stop displaying them in tag view

1ec5 commented 10 months ago

If the user decides not to edit the feature

in such case tags will not be autoremoved

I understand. My point is that this would be potentially just as confusing as:

In fact, if tags are shown during editing and then deleted automatically with no user interaction then it is more confusing for user

It’s literally the reverse situation. So I think a more user-friendly and possibly more straightforward change would be to style the discardable tags differently. There’s no way to style individual tags in the text view, but that’s a raw, advanced representation of a raw, advanced representation. If that’s a showstopper, I wonder what practical problem it would solve.

Here’s more or less where an additional HTML class would be set if the key is discardable:

https://github.com/openstreetmap/iD/blob/407360943ce5db9d98e857f6148c7876d789ff37/modules/ui/sections/raw_tag_editor.js#L159

The styling could be similar to the styling for tags in a read-only view, maybe with the addition of text-decoration: line-through:

https://github.com/openstreetmap/iD/blob/407360943ce5db9d98e857f6148c7876d789ff37/css/80_app.css#L2653-L2661

matkoniecz commented 10 months ago

If that’s a showstopper, I wonder what practical problem it would solve.

some people wanted to run bot edit removing created_by to stop confusing display in iD (including raw tag display)

(just running bot edit and removing created_by is also an option, I guess)

matkoniecz commented 9 months ago

tyrasd added usability good first issue

so it is accepted as a good idea and just waits for someone to implement it, right?

KrishavRajSingh commented 9 months ago

is this open?

matkoniecz commented 9 months ago

is this open?

yes

screen

gy-mate commented 5 months ago

tyrasd added usability good first issue

so it is accepted as a good idea and just waits for someone to implement it, right?

@tyrasd?

1ec5 commented 5 months ago

just running bot edit and removing created_by is also an option, I guess

Yes, it is an option and a better alternative to your proposal, in my opinion. If these tags are so harmful that users shouldn’t see them, then a bulk edit would prevent these tags from appearing on osm.org and in other editors. On the other hand, if that would be too drastic, then iD can simply style the tags differently, as I described above. Keep in mind that users are more likely to see these tags on osm.org than in iD’s raw tag editor, which is hidden by default.