Open emersonveenstra opened 6 months ago
This one is a bit tricky. Yes, hotels can also be mapped independently of their building, but the vast majority (about 85%[^1]) are currently mapped together with the building tag. Changing the preset would make mapping the majority of cases less simple. Note that the existing preset does only require one additional click to remove the building tag from the object when one wants to map a hotel campus.
Since there's already a "Hotel Building" preset,
That preset is actually a little misleading, as it refers to buildings whose design/architecture/construction is that of a hotel (e.g. a building with many individually accessible rooms), independently of whether it is used as a hotel or not.
What we could potentially do to improve the tagging schema is to add a dedicated preset for hotels not mapped together with a building. This preset would not include the building
tag and field and could be labeled as "Hotel (Campus)", or perhaps better "Hotel Complex"?!
This would result in the following presets being available in iD:
tag | preset name | matchScore |
---|---|---|
tourism=hotel + building=* |
Hotel | 1 |
tourism=hotel |
Hotel Complex | 0.75? |
building=hotel |
Hotel Building | 0.5 |
Does that look reasonable?
[^1]: source: taginfo https://taginfo.openstreetmap.org/tags/tourism=hotel?filter=ways#combinations
What we could potentially do to improve the tagging schema is to add a dedicated preset for hotels not mapped together with a building.
Can we use the same pattern as for school building vs school ground? I think that works well and is the same kind of issue, right?
We could of course. The differences here are that for amenity=school
the combined use with building=*
is much much less common (~7%) than for hotels (~85%) and that the wiki does only recommend the combined use for hotels, but not for schools. Surely that difference in usage should somehow be reflected in the presets?!
Describe the bug The Motel and Hotel presets should not add
building=yes
since one of the valid ways to map a motel and hotel is to draw an area around the entire grounds, and then add the buildings asbuilding=motel/hotel
inside the areaExpected behavior Since there's already a "Hotel Building" preset, imo the easiest thing to do is remove the building tag from the Hotel preset, then add a Motel Building to match the hotel presets