Preset leisure=disc_golf_course might be wrong

[natrius]

Describe the bug

According to https://github.com/openstreetmap/iD/commit/839d922ea6f300425248bf6094a00733d0f52cfd the tag sport=disc_golf is added when tagging leisure=disc_golf_course, but according to https://wiki.openstreetmap.org/wiki/Tag:leisure%3Ddisc_golf_course disc_golf_course already implies a sport=disc_golf - so its not needed.

    "addTags": {
        "leisure": "disc_golf_course",
        "sport": "disc_golf"
    },

To Reproduce Steps to reproduce the behavior:

1. Add a relation with leisure=disc_golf_course and upload

I was not able to reproduce it (no new golf course at hand right now and i mainly use JOSM) but i got word from another user who entered one recently with iD and encountered this.

Feel free to close.

[matkoniecz]

I was not able to reproduce it (no new golf course at hand right now and i mainly use JOSM)

you can make test edit without saving it

Disc golf course preset applies in fact

leisure=disc_golf_course
sport=disc_golf

(I have no opinion or knowledge is it a good thing, though note that tag A implying tag B does not mean that adding both A and B is wrong)

[Hufkratzer]

note that tag A implying tag B does not mean that adding both A and B is wrong

... but it is unnecessaty. So why do it? The preset for leisure=fishing does not add sport=fishing