openstreetmap / id-tagging-schema

🆔🏷 The presets and other tagging data used by the iD editor
ISC License
160 stars 164 forks source link

Add building:levels to building=construction #1258

Open maro-21 opened 5 months ago

maro-21 commented 5 months ago

[moved from https://github.com/openstreetmap/iD/issues/10187]

Buildings under construction also have floors... And this field is not in this preset at all. To add floors, I have to first select another building type, add the number of floors, and then change to building=construction.

kjonosm commented 5 months ago

It is not clear whether building:levels refers to the number of levels already constructed on site or the total number of building levels once construction is finished. Hence, I would recommend to not add this tag to building=construction.

maro-21 commented 5 months ago

Refers to the number of levels already constructed. I often update number of levels for buildings in my area.

tordans commented 5 months ago

@maro-21 can you share a wiki docs link where this is documented? The field-description will not be helpful in this case, because it cannot have different info text based on other tags. But at least we should have some documentation on this somewhere…

maro-21 commented 5 months ago

building:levels is commonly used with building=construction: https://taginfo.openstreetmap.org/tags/building%3Dconstruction#combinations

The field-description will not be helpful in this case, because it cannot have different info text based on other tags. But at least we should have some documentation on this somewhere…

What do you mean? Which field description?

maro-21 commented 5 months ago

It is not clear whether building:levels refers to the number of levels already constructed on site or the total number of building levels once construction is finished.

Good reasoning, but it refers to the number of levels already constructed because we don't map future [at least not in these tags] and a building may already have the target number of floors and still be under construction, sometimes for many months or years.

tordans commented 5 months ago

building:levels is commonly used with building=construction: https://taginfo.openstreetmap.org/tags/building%3Dconstruction#combinations

usage: 78.728 in kombination with building=construction.

image

The field-description will not be helpful in this case, because it cannot have different info text based on other tags. But at least we should have some documentation on this somewhere…

What do you mean? Which field description?

The part behind the info-i of the field: image It will show the same text in the construction case as it does now.

Good reasoning, but it refers to the number of levels already constructed…

I think once the wiki https://wiki.openstreetmap.org/wiki/Key:building:levels and https://wiki.openstreetmap.org/wiki/Tag:building=construction has a section on this so there is clear community documentation we can add this preset without any hesitation.