Water tap present should tag `amenity=drinking_water` instead of `drinking_water=yes` if tap supplies drinking water

[osmuser63783]

Try mapping a tap that supplies drinking water, there are a least two relevant presets: the water tap preset (man_made=water_tap) and the drinking water preset (amenity=drinking_water).

The water tap preset asks if the water is drinkable and sets drinking_water=yes if it is, and =no if it isn't. I would suggest that it should tag amenity=drinking_water instead of drinking_water=yes, if it is drinking water. (It can continue to set drinking_water=no if it isn't.) The fact that the amenity=drinking_water is a tap can be tagged by combining amenity=drinking_water with man_made=water_tap.

Reasons in favour:

• a lot of data consumers expect any drinking water source to have the tag amenity=drinking_water: of the six featured layers on osm.org, five will only show the tap if it has amenity=drinking_water. Only one layer (CyclOSM) will show a man_made=water_tap with drinking_water=yes
• this leads to counterintuitive results: a mapper who used iD to add a water tap that supplies drinking water and used the man_made=water_tap preset, was understandably surprised why their tap didn't show on the map (example)
• in the data, there are 18 916 combinations of man_made=water_tap with amenity=drinking_water and only 7 739 combinations of man_made=water_tap with drinking_water=yes. So amenity=drinking_water seems to be the preferred way of tagging a tap with drinking water
• the amenity=drinking_water Wiki page is clear that a tap that supplies drinking water fits the definition, and the examples show the combination of amenity=drinking_water and man_made=water_tap of amenity=drinking_water. The water_tap page is less clear but in all the tagging examples, when the tag supplies drinking water it always has amenity=drinking_water (sometimes in addition to drinking_water=yes)

Reasons against:

• the only real reason I can think of would be if there's a semantic difference between a "source of drinking water that is a tap" (amenity=drinking_water man_made=water_tap) and a "tap that supplies drinking water" (man_made=water_tap drinking_water=yes), but that seems rather tenuous

I asked the question in the community forum and although there were voices on both sides of the argument, only one person tried to make the argument that the two are semantically different, but no else one agreed with them. Most people agreed the current situation is less than ideal.

[tordans]

I don't think the current schema supports this mapping, does it?

Maybe we could use the deprecation rules as a work around to rework the "wrong" tags after they where added by the field?

[osmuser63783]

The current schema supports adding an amenity=drinking_water but it doesn't ask what the drinking water is from (water fountain, tap, well, spring..)

[tordans]

I just read about the replacement key that might be a solution for this issue. Maybe someone can try to set this up that man_made=water_tap+ drinking_water=yes triggers the replacement for a new, unsearchable preset of man_made=water_tap+amenity=drinking_water (that would be the desired tagging, yes?)?