search

openstreetmap / id-tagging-schema

🆔🏷 The presets and other tagging data used by the iD editor
ISC License
137 stars 148 forks source link

Add preset for leisure=bathing_place (#1217) #1274

Closed osmuser63783 closed 3 days ago

osmuser63783 commented 1 week ago

Description, Motivation & Context

Böhmerheide_-_Badestelle_Landseite (source)

A bathing place (German: Badestelle, Swedish: badplats) is a designated spot where you can swim or 'bathe'. In Europe these are often signposted by the local authority, as these are the spots where swimming is officially allowed or encouraged, water quality monitored, etc.

The English translation 'bathing place' is a bit awkward but I think the concept of a designated or widely known spot for outdoor swimming is a global one. I have tried to suggest a few synonyms.

leisure=bathing_place has existed for many years as a tag, but bathing places have also been mapped using various other tags that don't really fit e.g. leisure=water_park and I think that's partly because a preset for leisure=bathing_place isn't more widely available.

The tagging scheme does already contain a preset for leisure=swimming_area, for areas only. In a recent community forum discussion it was agreed that leisure=swimming_area is for the part of the water that has been roped off or otherwise clearly designated for swimming, whereas a leisure=bathing_place doesn't usually have a clearly defined boundary so it will usually be mapped as a node. It's a POI - in some languages, people say the equivalent of "let's meet at the bathing place".

Related issues

Closes #1217.

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Hufkratzer commented 1 week ago

Shouldn't the preset also be allowed for areas? Some are mapped as an area, e.g. https://www.openstreetmap.org/way/1203484522, https://www.openstreetmap.org/way/56313252

osmuser63783 commented 1 week ago

It would also be great to have a few screenshots on the search so we can see that there are no weird results where users would now pick a wrong answer due to the new preset.

Thanks, how do I get the bot to trigger that lets me preview it? I can't spot any obvious syntax errors

tordans commented 1 week ago

Thanks, how do I get the bot to trigger that lets me preview it?

Sorry, did not catch that this was not triggered yet. The setup is that for first contributors, someone with permissions has to trigger the checks. On Action will be to create the preview and comment on the PR with the link. That will happen in a few minutes. For your next PR, this will run automatically.

github-actions[bot] commented 1 week ago

:bento: You can preview the tagging presets of this pull request here.

osmuser63783 commented 1 week ago

I’ve added the informal field, removed the moreFields, added area as possible geometry and used Camel Case for the aliases and name.

This leaves the icon. I can’t find a better one among the existing icon sets I’m afraid but maybe someone else has more luck?

Here are some screenshots.

Screenshot 2024-07-02 at 23 43 46 Screenshot 2024-07-02 at 23 41 32 Screenshot 2024-07-02 at 23 45 32
tordans commented 5 days ago

Thanks @osmuser63783 for the update.

On the topic of the Icon: How about this for a quick fix…

  1. We change https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/public_bath.json#L2 to the Ladder+Water Icon you use now Reading the wiki this is a good fit, because there will likely be some kind of formal facility (and a ladder)

  2. We then use the water drop for the new preset "Bathing Place". Usually I would say this icon is not good for bathing at all… but given the fact that we used it for the other preset for a while now, it seems to work well enough. And the fact that it is more generic / more plain water, fits the more inoffical style of leisure=bathing_place.

osmuser63783 commented 4 days ago

Thanks, I've swapped the icons!

tordans commented 3 days ago

Thanks for the update @osmuser63783 I think this is ready to be merged, now.

Two things I notices that I wanted to document here:

Wiki defintions: The german wiki page and wikidata entry was different from englisch, in that it said that the tag should only be applied to official and public places. I modified wikidata and added a callout to the wiki page https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dbathing_place . I think it is OK to merge this as is and see if any feedback comes up.

Rendering conflict: The area example from above https://www.openstreetmap.org/way/1203484522 has non-ideal rendering in iD. It does pick the right preset, but the rendering is based on the landuse=grass tag. I would consider this a non ideal tagging, so I think it is not an issue for this ticket.

osmuser63783 commented 16 hours ago

Thanks! Yes, the German Wiki hasn't been updated yet following the international discussion that led to the English page looking the way it does.