openstreetmap / id-tagging-schema

🆔🏷 The presets and other tagging data used by the iD editor
ISC License
154 stars 153 forks source link

Make leisure=fitness_station preset same as leisure=playground #1301

Open radioxoma opened 1 month ago

radioxoma commented 1 month ago

Hello! I don't quite get a reason of difference between playground and fitness_station iD presets. Both places are basically the same, only user age changes.

Current iD preset:

My proposal is to change iD fitness station preset:

  1. Tag leisure=fitness_station for areas and nodes. Like wiki page suggests and JOSM does
  2. fitness_station=<equipment_type> for nodes (drop leisure=fitness_station, sport=fitness tags), just like playground preset

Why force sport=fitness? It's obvious that leisure=fitness_station implicitly related to some broad sport categories (resistance training, cardiorespiratory training, mobility) and this tag doesn't specify any additional info beyond that. Same equipment is used in different sports (e.g. horizontal_bar for back+bicep training in weightlifting and gymnastics/calisthenics elements, and can be found even on playgrounds). Also fitness is not a sport, it's a lifestyle, but this point not related to the issue.

tordans commented 1 month ago

Research notes

https://wiki.openstreetmap.org/wiki/Tag:sport%3Dfitness

How to map Place a node node at the centre of the facility or draw an area area around the surface, and add leisure=fitness_centre or leisure=fitness_station sport=fitness fitness_station=* - type of single device

Hufkratzer commented 1 month ago

I am not sure if I understand the wiki correctly, but I think there is a difference between fitness_station=* and playground=*: fitness_station=* means: this is a leisure=fitness_station of type fitness_station=* (must also have tag leisure=fitness_station), but playgound=* means: this is an equipment (part) of a leisure=playground (the equipment itself should not have tag leisure=playground). Compare related forum discussion.

According to the wiki page for leisure=fitness_station, leisure=fitness_station implies sport=fitness. So if fitness_station=* specifies the type of a leisure=fitness_station and needs this tag, sport=fitness is implied automatically and the explicit sport tag is not needed.

radioxoma commented 1 month ago

Both leisure=playground and leisure=fitness_station should be areas, but iD fitness station preset doesn't allows it. Equipment (playgound=*, fitness_station=*) should be separate nodes inside leisure=* area.

sport=* not mandatory and shouldn't be forced by iD preset.

tordans commented 1 month ago

I think the differences in presets come from the fact, that fitness stations are more often stand alone objects but playground equipment is not. Playgrounds are usually a group of equipment and with some kind of enclosure.

I see this changing in my area in the last few years, so we might have to revisit this. The issue will be, that there is no good way in this schema or iD to explain to users how to map something that needs and area first and then equipment features on this area. We have quite a few tickets on the issue of school grounds vs. school building because of this.

If we where to remove the primary tag from fitness station equipment by default, we would need something like a "check" field that allows to klick "this is a standalone equipment yes/no" in order to nudge users to add the tag the same way we do today.

Here are a few examples for illustration