openstreetmap / id-tagging-schema

🆔🏷 The presets and other tagging data used by the iD editor
ISC License
160 stars 164 forks source link

Enhance camp_site and caravan_site preset fields #26

Closed hiddewie closed 4 months ago

hiddewie commented 4 years ago

I would like to request a number of fields to be added to the tourism camp_site and caravan_site presets:

The reason that these fields are important, is for finding a camp site with a certain vehicle or with a tent. Without these properties, camp sites may not allow access for camping with the vehicle/tent at hand. Situations like this occur when:

Editors like iD and JOSM are the first point to improve the tagging experience for mappers. JOSM has a good preset, but the iD preset is lacking the required fields.

The open camping map visualizes this well.

Also see this tagging mailing list conversation about differentiating caravan_site and camp_site.


If I can make the time I will also try a pull request for this enhancement.


iD screenshot of camp_site preset:

image

JOSM screenshot of camp_site preset:

image

//edit @tyrasd

checklist for proposed fields:

dustinblainemyers commented 4 years ago

I added this under "fields" instead of "moreFields" since I saw you use the words "required" and "important" in your request. Let me know if this was the incorrect interpretation and I can fix it. I believe I followed the correct procedures according to the contributing guidelines but this is my first time contributing. Let me know if I can improve on anything.

Example of Change Under "Backcountry Camping Area " feature: image

Link to pull request:

https://github.com/openstreetmap/iD/pull/7955/commits

hiddewie commented 4 years ago

@dustinblainemyers Thanks for implementing this request! It looks really good, and will hopefully improve the tagging of campings and caravan sites!

dustinblainemyers commented 4 years ago

Awesome! Glad I could help.

TheAdventurer64 commented 4 years ago

Shouldn't this be closed by now?

hiddewie commented 4 years ago

The pull request that implements this feature is still open, and once it is merged this issue can be closed (automatically?).

osmuser63783 commented 4 months ago

I think this issue can be closed, as the fields requested are all part of the preset? Plus separate presets for backcountry and group-only campsites.

tordans commented 4 months ago

All right. I did not check it in detail but I see a few linked PRs. Please create a new issue if something is missing.

hiddewie commented 4 months ago

Thanks everybody involved for the work improving this preset!