openstreetmap / id-tagging-schema

🆔🏷 The presets and other tagging data used by the iD editor
ISC License
160 stars 163 forks source link

For storage tanks: have a box: covered? (but set no default) #344

Open jidanni opened 3 years ago

jidanni commented 3 years ago

For storage tanks, have a box

Where "no" is the exception, 20211010T210023

AntMadeira commented 3 years ago

I second that. In arid and forested areas, is important to tag if the water tanks are covered or not. I always have to add the covered=yes/no tag, but this would be helpful.

jjiglesiasg commented 2 years ago

Well in several places of the world is the other way, covered is the exception and Not the rule, indeed mostly of South America and Africa are Uncovered, basically because the cost of construction raise exponencially.

jidanni commented 2 years ago

Hmm, https://www.google.com/search?q=should+you+cover+a+water+tank? says covering it is important...

jjiglesiasg commented 2 years ago

I understand what you said, but minor and personal (household) small water tanks are usually NOT mapped but large constructed tanks with concrete walls and located in agricultural, natural parks, highlands and water deprived areas and Mostrly if not All are Uncovered.

AntMadeira commented 2 years ago

Well in several places of the world is the other way, covered is the exception and Not the rule, indeed mostly of South America and Africa are Uncovered, basically because the cost of construction raise exponencially.

Actually, it is irrelevant if it's the exception. We're merely asking for a selection box to add a tag saying if the storage tank is covered or not.

jjiglesiasg commented 2 years ago

Well in several places of the world is the other way, covered is the exception and Not the rule, indeed mostly of South America and Africa are Uncovered, basically because the cost of construction raise exponencially.

Actually, it is irrelevant if it's the exception. We're merely asking for a selection box to add a tag saying if the storage tank is covered or not.

Them I do agree with you, currently such feature is not an option in the menu for Storage Tanks. Should be like Driveways under roofs for example...

tyrasd commented 2 years ago

I've only added this field (in 889821d) for water tanks (i.e. man_made=storage_tank + content=water) for now, because for many other tank types this tag doesn't seem to apply or is simply not used (ignoring of the apparently implied covered=yes value), e.g. for all tanks holding gasses, or substances like oil, chemicals, hot water, etc.

AntMadeira commented 2 years ago

That seems reasonable. Thanks!

AntMadeira commented 2 years ago

@tyrasd

Hi there again. In the last update, the covered field was added to emergency=water_tank + landuse=reservoir (btw this tag has been deprecated), but not to building=yes + content=water + man_made=storage_tank, which is a very used preset in iD. Can you please also add it?

Thanks.

AntMadeira commented 1 year ago

Hi there. Just to bump this request. The preset for building=yes + content=water + man_made=storage_tank still doesn't have the covered=* field. The field would also be very useful for building=yes + content=water + man_made=storage_tank + emergency=water_tank.

Regards.

tyrasd commented 1 year ago

The covered field is present as an optional field on both the "Water Tank" and "Emergency Water Tank" presets:


I guess you mean that this field should be promoted to a regular field which is always shown to mappers for these presets?

I think I initially only implemented this as an optional field because of two reasons:

AntMadeira commented 1 year ago

I can live with that hidden field, even if its not always shown to mappers as a regular field. Nevertheless, this is important for me because I live in an area prone to wild fires in the summer and there area many water reservoirs scattered in the mountains. I can not map them all, but those who map them and know only what they see in iD, should know that there's an option to clearly differentiate covered from open emergency water reservoirs, which is important to those who fight the fires.

I edited the wiki to clearly state that it includes "an area such as an underground parking lot, a covered reservoir/cistern or even such things as an aquarium", which is the text that was written originally in the approved proposal.

Regards.