Open nc011 opened 2 years ago
tyrasd
commented
2 years ago in 224de53, I've added a field to specify the "usage type" of canals, which includes the value for spillways.
For the moment this works, but it would be nice to add a dedicated preset for spillways (and perhaps other types of canals) eventually. This would require making a better icon for it.
nc011
commented
2 years ago Seems like a sensible compromise.
I note that the number of options for usage in various parts of your commit is different. I'd suggest using the values listed here: https://wiki.openstreetmap.org/wiki/Key:usage#With_waterways
Thanks!
tyrasd
commented
2 years ago I went with the options listed at https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dcanal#Usage
It seems to miss the option for usage=penstock which is supposed to be used only on pipelines as far as I can tell. And the pipeline page lists a few additional values (flowline, gathering, injection, flare_header,facility`). It would be best to have a dedicated field to show these values for pipelines only, right?
nc011
commented
2 years ago Those lists seems to be the same - so that's good. The main issue I was mentioning was that in some of the different files in your commit, you have missed some of the options.
| File | headrace | irrigation | spillway | tailrace | transmission | transportation | waterpower |
|---|---|---|---|---|---|---|---|
| usage_waterway.json | Y | Y | Y | Y | Y | Y | N |
| canal.json | Y | Y | Y | Y | N | N | Y |
| source_strings.yaml (3192) | Y | Y | Y | Y | Y | Y | N |
| source_strings.yaml (9875) | Y | Y | Y | Y | N | N | Y |
But perhaps I've misunderstood and this is correct!
tyrasd
commented
2 years ago Aah I see. That should be fine as is: the information in usage_waterway.json are the actual tag values, while in canal.json I only added a few additional search terms, where I intentionally skipped the in my eyes for a search term too generic strings transmission and transportation. source_strings.yaml only mirrors the information from the json files.
(Low importance)
The approved tagging scheme for a spillway is
waterway=canal+usage=spillway(and usually, but optionally, withintermittent=yes).It's not the most obvious tagging and so I think would benefit from a preset. Usage is relatively low (1,815 uses globally) but with over 750,000 reservoirs mapped in OSM (with most having a spillway) it seems that usage will eventually increase.