search

openstreetmap / id-tagging-schema

🆔🏷 The presets and other tagging data used by the iD editor
ISC License
137 stars 147 forks source link

popular unsupported values of major keys #529

Open matkoniecz opened 1 year ago

matkoniecz commented 1 year ago

Based on taginfo - so some may be fixed already (I noticed and removed barrier=log). Some have open PRs already. Some would be wrong to include, some would require checking.

Generated with https://github.com/matkoniecz/taginfo_api_wrapper_in_python#listing-popular-tags-unsupported-by-id

It is usable for review. But using it requires some thinking. For example I like shop = estate_agent and is in my opinion preferable to office = estate_agent (as office=estate_agent and other office=* is used both for places inaccessible to general population such as internal offices - and for ones accessible to general population, but changing id presents requires some investigation what other mappers think).

Note that some highly used values, are from imports of a low quality. That would allow filtering out values discussed separately and/or rejected. Many values initially on this list were filtered out and skipped.

If that list is useful - then more systematic reviewing like JOSM is doing may be useful.

Other potential comparisons: list tags supported by JOSM or Vespucci and not supported by iD.

tyrasd commented 1 year ago

Thanks for compiling this list. I've marked off a few which have been recently added to the repository: highway=speed_display, highway=emergency_access_point and some of the barrier options.

matkoniecz commented 1 year ago

added some issue links

barrier=handrail seems a good target for me.

barrier=debris 3k and power=catenary_mast 54k power=heliostat 18k looks like a niche but valid to include as far as I can see

highway=via_ferrata 2k seems a good idea, but likely should be verified with wider community

note: no significant research was done here

danieldegroot2 commented 1 year ago

@matkoniecz could you exclude power=abandoned:tower, please? It is obviously abandoned:power=tower.

matkoniecz commented 1 year ago

Noted in the list, opened some notes like https://www.openstreetmap.org/note/3277875 https://www.openstreetmap.org/note/3277873 https://www.openstreetmap.org/note/3277890 https://www.openstreetmap.org/note/3277888 https://www.openstreetmap.org/note/3277885

See https://taginfo.openstreetmap.org/tags/power=abandoned:tower#map and https://overpass-turbo.eu/s/1klr

westnordost commented 1 year ago

Regarding shop=estate_agent 4k, would

  1. a PR to deprecate shop=estate_agent and "upgrade" to office=estate_agent be accepted?
  2. or, would a PR to add a non-searchable preset (to not promote, but understand it) for shop=estate_agent be accepted?
matkoniecz commented 1 year ago

office=estate_agent has problem of mixing "place where actual clients can go and talk/actually buy real estate" and "internal office of company handling real estate, no entry for clients"

Second one would be better tagged office=company - maybe with company=real_estate

So can we avoid deprecation here?

matkoniecz commented 1 year ago

I added listing for keys such as: craft, man_made, advertising, aeroway, boundary, emergency, cycleway (and its variants), historic, military, route, sport, healthcare (with some dubious popular values excluded)

And marked natural=crevasse as ignored, as it is basically import only

danieldegroot2 commented 1 year ago

From existing list;

matkoniecz commented 1 year ago

edited

hamishmb commented 1 year ago

I'm an avid StreetCompleter, and end up creating notes for some of these things because there's not an in-app way to add them, or change them.

I think these cleanups are a good idea too - what does man_made = beam even mean anyway? Due to my autism, I probably get confused by these things more easily than some.

arch0345 commented 1 year ago

A preset for power=catenary_mast was added in #593

arch0345 commented 1 year ago

649 added a preset for power=portal in addition to man_made=gantry

A preset for power=terminal was proposed in #653

A preset for emergency=dry_riser_inlet was proposed in #642

matkoniecz commented 1 year ago

List updated.

k-yle commented 1 year ago

@matkoniecz irrigation=pivot isn't in the list, but it has 25k uses and presets in JOSM and Vespucci

matkoniecz commented 1 year ago

@k-yle That is because this list has only popular values of "major keys" (due to technical limitations and to avoid need for vading through import debris)

Feel free top open a new issue for it if support for that tag is needed/useful.

Dimitar5555 commented 1 year ago

There is a field for all cycleway(:*) values except for cycleway:both which is tracked in #743.

man_made=gantry has also been added.

matkoniecz commented 1 year ago

man_made=gantry has also been added.

marked

tyrasd commented 1 year ago

emergency = water_tank 24k

I think this tag is already covered well enough, as the documented tagging methods are already represented as presets:

Is there anything we have overlooked?

matkoniecz commented 1 year ago

marked as done

matkoniecz commented 1 year ago

cycleway:both which is tracked in https://github.com/openstreetmap/id-tagging-schema/issues/743.

marked

matkoniecz commented 1 year ago

@tyrasd

https://github.com/openstreetmap/id-tagging-schema/blob/v6.0.0/data/presets/emergency/water_tank.json

Why then emergency=water_tank is not listed at https://taginfo.openstreetmap.org/tags/emergency=water_tank#projects (as specific value, emergency=* is generically listed) ?

matkoniecz commented 2 months ago

Maybe closing this issue and generating new one like this would be useful? (this will take me about 10 minutes, including time to move linked issues/PRs, so it is more question whether new one will be more useful)