openstreetmap / id-tagging-schema

🆔🏷 The presets and other tagging data used by the iD editor
ISC License
156 stars 157 forks source link

Do not ask to update tags for public transportation stops in Norway #819

Open forteller opened 1 year ago

forteller commented 1 year ago

Hi, long time… :)

Not exactly a bug, but this seems to be the best place to ask for this, please let me know if there is a better place/way.

Here in Norway the national service for public transportation has a database of all stops for busses, metros, trams, etc. This db is regularly synced with OSM to keep OSM data current. Unfortunately, if anyone manually changes the stops, then the link is broken and that stop will no longer be automatically kept updated from the stop place registry db.

When editing maps in iD some public transport stops, at least some bus stops, prompts you to click a button to upgrade its tags.

image

This is normally very useful, but for these stops it's destructive, because it gets users who don't know about the linked stop place registry (= almost all) to think that they should click the button. This creates a lot of problems.

Is there any way for iD to not ask people to do this change when selecting a public transport stop within the borders of Norway? That would be incredibly helpful.

Edit: This can be verified at https://wiki.openstreetmap.org/wiki/Import/Catalogue/Bus_stop_import_Norway#Updates

Thanks!

tyrasd commented 1 year ago

Relevant section from the wiki:

Changes to names or coordinates in NSR will be reflected in OSM unless the bus stations and bus stops in question have been edited by anybody else than the user nsr2osm in OSM, in which case they will not be altered.

I assume updating the tooling to filter out certain edits (e.g. ones that are just adding the public_transport=platform tag) is out of scope?


It would be possible to add a regional preset for Norway's bus stops which omits the public_transport=platform tag, if the local convention is to not use that tag on bus stops.

matkoniecz commented 1 year ago

If "Do not suggest to add public_transport=platform for highway=bus_stop or highway=platform" (#716) would be accepted, it would be also fixed.

forteller commented 1 year ago

Sorry, it seems like the wiki is wrong and that any other edits than the tags name and ref, plus changing location, is totally fine.

So prompting to change any other tags than name and ref should be fine in regards to the link to the stop registry db. I'm not 100% sure yet, but I'm pretty sure. I'll keep this updated when I find out more.

Anyways, @matkoniecz is still correct that public_transport=platform should not be suggested for highway=bus_stop. highway=bus_stop is a point, while public_transport=platform is an area, encompassing the whole platform.

See this example:

image

The area marked in red is a platform. You can see the same kind of area on the other side of the road. If I click on the point named "Hasle (D)" iD suggests to add the public_transport=platform tag. This seems wrong.

https://www.openstreetmap.org/#map=19/59.92316/10.79249

Marc-marc-marc commented 1 year ago

I find the request very strange, osm is not designed to have an nearly unmodified copy of an opendata it is totally normal and good that contributors add information to osm objects, including public_transport tag when it's the correct one, the bug is not in iD but in the opendata workflow

about public_transport=platform, the proposal did not speak that it concerns only a way but (quoting the approved proposal) "where passengers are waiting for the vehicle. If there is no platform in the real world, one can place a node at the pole." And therefore for every stop, public_transport=plateform or public_transport=stop it is valid on highway=bus_stop(depends on the country, some put highway=bus_stop on the vehicle stop position, others on the passagenders waiting position, it is an advantage of the proposal to know if it is the place for the passenger or the vehicle) and create a 2nd object leads to duplications. unfortunately the value was badly chosen, it would have been better public_transport=passenger_waiting and public_transport=vehicle_stop to avoid this endless misunderstanding