search

openstreetmap / id-tagging-schema

🆔🏷 The presets and other tagging data used by the iD editor
ISC License
160 stars 164 forks source link

Add preset for amenity=ski_rental #9

Open Adamant36 opened 4 years ago

Adamant36 commented 4 years ago

It's similar to the other amenity tags related to renting things. There's currently about 500 uses of it. None of the other ways ski rental places are tagged are close to that in usage. Also, having a preset would be good for when I add some ski rental brands to the NSI. https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dski_rental

quincylvania commented 4 years ago

There doesn't appear to be consensus between this and using ski:rental=yes or rental=ski on shop=ski or shop=rental. I understand that not every ski rental place sells skis, but many, many do and it's a burden on data consumers to support yet another amenity tag versus a standard shop tag.

Adamant36 commented 4 years ago

There's a lot of purely rental places that aren't shops though. There's no reason they can't just be tagged as amenity=ski_rental and then the various other rental tags can be used where its a ski shop that also rents. Its already done in many other instances. You cant just something as rental=ski or ski:rental without another tag anyway. In most cases where rental=ski was used it was being co-tagged with amenity=ski_rental or all three of the options were being used on the same object with something weird like shop=ski and sales=no. At least amenity=ski_rental could at least be used in those cases, where its clear cut like amenity=car_rental so there isnt a bunch of weird tagging. Then the other tags can be used to better describe actual ski shops that also rent skis. Which is how I think the other tags were intended. Id have zero problem with that. You could never tag a place as just rental=ski though if it just rents skis. There'd always need to be a half weird tag that only sorta fits added with it like shop=rental/ski/sports/pickone and some kind of sales=no qulifier tag, but that's not the case with amenity=ski_rental. Its fine alone.