search

openstreetmap / leaflet-osm

OpenStreetMap plugin for Leaflet
Other
111 stars 32 forks source link

Remove node engine version check #30

Closed bagage closed 2 months ago

bagage commented 3 years ago

This prevents using this library with yarn which does check that used version of node is compatible with the library.

I do not think this library has any strong requirement regarding node version.

tomhughes commented 3 years ago

Well the version in the npm registry is ancient anyway and I assume it's only @jfirebaugh that has access to publish an update there. I certainly don't.

bagage commented 3 years ago

Some project (at least osmose) uses the master branch version directly, so it's still worth having it merged I think?

frodrigo commented 2 years ago

Well. Now I try to update this dependency in Osmose-QA and nowadays both yarn and npm block on this engines.node field.

I also think it could be harmless removed.

tomhughes commented 2 months ago

It does seem to be nonsensical in the modern age, so let's get rid of it...