search

openstreetmap / merkaartor

Home of Merkaartor, an openstreetmap mapping program.
http://merkaartor.be/
Other
298 stars 78 forks source link

Implement Ctrl+drag to add to selection #11

Open Krakonos opened 9 years ago

Krakonos commented 9 years ago

It was suggested in old redmine bug 3251, by Jonathan Bennett:

Pressing Control while drag-selecting should add to the current selection. At present it doesn't modify the behaviour of a drag, but does of a click-select.

If it's easy to implement, Control-Shift-drag could subtract from the selection as well.

vaibhav135 commented 4 years ago

@Krakonos may i start working with this issue..

Krakonos commented 4 years ago

Sure, I'd also be happy to provide you assistance if you have any questions. I would suggest looking into the current handling (click-select should have this feature) and duplicate that in drag-selection. It might also be worth abstracting some of the common code to a function, but I think it should be dead simple once you find the correct spot.

Once you have something, don't hesitate to create a pull request for review, even if the code needs more work.

vaibhav135 commented 4 years ago

@Krakonos Sir, I know that this is a very amateur question but how may I know which of the modules are performing a certain functionality. Also, is current Handling a folder? if it is I couldn't find it. Do I need to add the whole osm repository to my local machine or would it be enough for me to just add merkaartor(which I have already done) to add this feature? I am sorry for these silly questions but since I am a sophomore I want to contribute. Also, @KraKonos is your organization going to participate in GSoC this year too.

Krakonos commented 4 years ago

Hi!

No worries: 1) You only need the merkaartor repository. Please read COMPILING.md and HACKING.md to start you up on the build process. 2) Finding the right spot is a bit hard for larger projects; but usually you can orient yourself relatively quickly and find the rough spot with a little bit of luck; then you have to study that a bit more to find the exact place to put your code in, so it works well with the rest of the system. I can hint you that the UI interactions are in src/Interactions, I think the selection is handled in EditInteraction, but look around for uses of setSelection method. 3) I do not plan to participate in GSoC. However, I believe OSM participates regularly: https://wiki.openstreetmap.org/wiki/Google_Summer_of_Code/2019

vaibhav135 commented 4 years ago

@Krakonos sir, Will contributing to Merkaator help me in the process of GSoC if I wish to work with OSM. Since merkaator is a part of osm, or do I have to contribute to somewhere else for GSoC. Quick update: @Krakonos sir I have found the documentation for Merkaator and it is very helpful. Thanks for the help, sir! wish to get an update from you soon.

Krakonos commented 4 years ago

I'm not really sure how that helps to GSoC. I'd suggest contacting someone directly in OSM foundation, they'll know more.

vaibhav135 commented 4 years ago

@Krakonos I have filled the bbox with some specific longitudes and latitudes in merkaartor now it looks like this. Is it suppose to look like this. Hey if I am going in the right direction please update me. Should I start checking for the Implement Ctrl+drag to add to selection #11 Screenshot from 2020-01-17 15-02-31

Krakonos commented 4 years ago

Looks fine. The read dots show area that wasn't fully downloaded (the things there might be part of some relation?)