Closed KAMiKAZOW closed 3 years ago
It's always the windows installers. Can you double check the -rc1?
RC1 works (the installer is also 25MB bigger). Installing 0.19.0 on top of RC1 works as well.
Ok, let me check what's going on, as I have tested master just a few days ago and even added more libraries to fix some github actions issues.
If it's not too much work, you could use the community LTS branches of Qt 5.15 (available at https://invent.kde.org/qt/qt/qtbase/-/commits/kde/5.15 in case of qtbase) instead of 5.12 if you need to touch dependencies anyway.
It appears windeployqt is no longer doing it's job and fails to find libicu. I do have a hunch, I'm running a check in PR #258.
Qt 5.15 - you mean for windows? On windows, I'll use whatever is in MSYS2 upstream, unless there is a very straightforward way to integrate it into MSYS2. The same for OSX and Homebrew. On Linux, you can compile against 5.15 if you'd like - I do it myself.
I wasn't aware how the dependencies were handled on Windows. It's not critical and just a mere suggestion if you have to rebuild everything anyway.
Ok, my hunch wasn't correct. My best guess is something changed in the build environment. Unfortunately, I know of no easy way to have a more stable environment. I'll try to reproduce locally and see why the lib isn't being found. There is a history with this library on MSYS2 giving problems..
Just did a bit of digging and it seems there is an issue with the latest qt5 build in MSYS2:
https://github.com/msys2/MINGW-packages/issues/9475 https://github.com/msys2/MINGW-packages/pull/9477
I will rebuild the windows package with the patched qt once the PR gets merged (should be soon, as it's really a bugfix - the PKGBUILD introduced second prepare() function and the MSYS2 patch fixing this specific problem was not applied.
The failed packages are updated. Please update msys2 packages using pacman -Syyuu
and check if the program works.
Thanks. I run the build and it appears to work. @KAMiKAZOW would you mind testing?
https://cloudsmith.io/~merkaartor/repos/merkaartor-nightly/packages/?q=version%3A0.19.0
If it works, I'll sign this build and publish it instead of the win64 (as 0.19.0-1, noting the issue, but deleting the broken one).
Completely wiped the old installation (= remove C:\Program Files\Merkaartor manually after uninstall) and it works now. Thanks.
I published the updated installers and merged #258 to make sure the build fails in case similar issue with windeployqt is reintroduced.
Very good efforts, guys! Maybe we can also an update on http://merkaartor.be/ about the new release?
HTTP? 😨
Will do today. https is coming in the near future, but I need to migrate the hosting first to support it properly (I'm not going to manage the certs manually).