search

openstreetmap / merkaartor

Home of Merkaartor, an openstreetmap mapping program.
http://merkaartor.be/
Other
290 stars 79 forks source link

Proj4 version in main.cpp not set correctly? #262

Closed RM87 closed 1 year ago

RM87 commented 2 years ago

Compiles again on Debian 11 after that change

Krakonos commented 2 years ago

Weird. See src/common/AboutDialog.ui:34, the dialog appears to have 'ProjVersion', not 'Proj4Version' - which is confirmed by Github Actions failing on this specific line. Is there a patch in debian packaging changing the dialog?

          <item row="2" column="1">
34>        <widget class="QLabel" name="ProjVersion">
            <property name="styleSheet">
             <string notr="true">QLabel { font-size:small; font-weight:bold; }</string>
            </property>
            <property name="text">
             <string notr="true">%1</string>
            </property>
           </widget>
          </item>
Krakonos commented 1 year ago

The change is incorrect, as the project does not compile cleanly and obviously uses different name than in the dialog. Rejecting.