openstreetmap / merkaartor

Home of Merkaartor, an openstreetmap mapping program.
http://merkaartor.be/
Other
290 stars 79 forks source link

Importing a jpeg doesn't work #272

Open l29ah opened 2 years ago

l29ah commented 2 years ago

0.19.0 here. Repro: File -> Import, pick, the image preview shows up, Load without associated node, the image doesn't appear anywhere.

Krakonos commented 1 year ago

The option Load without associated node is weird. I'm not sure how it's supposed to work (I'm not the original author), looking at the code, it just inserts the image without a node - which obviously is not rendered anywhere. What behavior would you expect?

The whole dialog shows only when there is no coordinate data in the picture metadata - properly geotagged images are just imported without the dialog.

l29ah commented 1 year ago

I hoped to be able to pick where to place the image, so that it would become a map background for air-surveyed mapping.

Krakonos commented 1 year ago

This is not how the JPEG would be imported anyway. Importing a JPEG like that would create a trackpoint with the image next to it, but it does not scale with the background, so it's not usable for this purpose.

A much closer feature would be to use a Walking Papers background; however, that would require you to add a QR code/barcode onto the page with the coordinates (and I'm not sure if that works well - it's not very used or tested).

Krakonos commented 1 year ago

There is one actionable item, and that is to fix the behavior of Load without associated node by one of the following ways:

  1. Allow selection of the new position (likely rename it to Select position from map)
  2. Fix the GeoImage dock to show list of all images (currently on my machine it is empty, which is likely a bug).
  3. Remove the option alltogether.

I'll have a look, likely option 2 will solve it and will be easiest UI-wise.