Closed xEtherealx closed 3 years ago
why is this needed? Unless you plan to offer to maintain this script for many years into the future I would recommend just posting it to the osm2pgsql as a resource for others and not including in the source code.
There is already an init script in the debian subdir of the repository, so it seems reasonable to include an init script for fedora as well. The question is where best to put it and what to call it to keep a bit of order in the directory.
Also, the script does actually look very similar to the debian script, so I am wondering if it is possible to unify the two init scripts?
Fedora has been moving to systemd service files, so there's no point in including an init.d script for that. RHEL 6 and derivatives could still use an init script. As for maintenance, once you have one that works well there's not usually a lot of changes to be made.
Looking quickly at the above script though I'd change the paths to use /usr and not /usr/local. /etc/default is a Debianism, Fedora/RedHat uses /etc/sysconfig. If this was a pull request I'd be able to comment on individual lines and I'd have a bit more to say.
I'd be happy to maintain the file if that floats your boat, but as previously stated it should really need to maintenance. The path locations are as installed with no --prefix flag given in the configuration step, and the /etc/default is a copy/paste error.
Could really use some guidance on creating this script for the rhel 7.2 distribution.
To me it seems this is an old issue. Most distros -including rhel from version 7 on - rely on systemd. I'm going to close this issue, please contribute to #218 for supporting a systemd service unit when compiling and #232 for overall support for Fedora and Red Hat.
Example script (basic but fully functional) provided.
/etc/init.d/renderd