search

openstreetmap / openstreetmap-website

The Rails application that powers OpenStreetMap
https://www.openstreetmap.org/
GNU General Public License v2.0
2.17k stars 911 forks source link

Link secondary WIkipedia tags - brand:wikipedia, operator:wikipedia, subject:wikipedia etc #2184

Closed matkoniecz closed 1 year ago

matkoniecz commented 5 years ago

Currently wikipedia article specified in wikipedia tag is linked in tag list.

But there are also secondary Wikipedia tags like subject:wikipedia that are not linked. It would be desirable to create link for both cases.

Selection_006

Selection_007

See https://www.openstreetmap.org/node/5167698292 and https://www.openstreetmap.org/node/1350073645

See https://wiki.openstreetmap.org/wiki/Key:wikipedia#Secondary_Wikipedia_links

See https://taginfo.openstreetmap.org//search?q=%3Awikipedia

brand:wikipedia, operator:wikipedia, species:wikipedia, subject:wikipedia, name:wikipedia, architect:wikipedia, artist:wikipedia, name:etymology:wikipedia are probably ones worth linking

HolgerJeromin commented 5 years ago

Ref #788

nachanon commented 5 years ago

This bug is still reproducible.

I have recently added an OpenStreetMap node-type POI representing a memorial statue (historic=memorial,memorial=statue) with information on the person statue represents in the in the subject:wikipedia key, using the same format as wikipedia tag.

But as soon as I tried to verify the entered entry on main OpenStreetMap interface, I found that the subject:wikipedia key's name was properly linked to its OSM Wiki description, but the key's value is not linked to Wikipedia article in question...

Other similar examples could be found via an Overpass query (Turbo, Raw) (139 nodes, 10 ways, 1 relation POIs at the time of this writing). I have picked several samples of them at random, and found the same problem when viewed on main OpenStreetMap interface.

The subject:wikipedia is quite important for statue POI, since statue often not having its own Wikipedia entry, while the person/subject it represents usually has one.

While some people would argue that one could find associated Wikipedia entries via Wikidata link anyway; doing it this way can be time-consuming where there is a lot of linkage information (large Statements section) on the Wikidata page in question— which is also the case for the POI shown in my screenshot.

Notes:

Browser: Pale Moon 25.8.1 (binary)
System: Debian GNU/Linux 7.0 Wheezy i386

matkoniecz commented 5 years ago

This bug is still reproducible.

Note that it is not a bug, it is a request for a new feature. Also "is still reproducible" is already known given that this issue is open.

alesarrett commented 4 years ago

I'm also supporting this enhancement request, given also the issue #834 recently solved.

boothym commented 4 years ago

Would be good if this was implemented - seems strange to have brand:wikidata linked but not brand:wikipedia.

matkoniecz commented 4 years ago

This issue is open, it means that it is waiting for someone to implement it (or review a submited pull request). In general, in open source projects you can either implement it by yourself or wait for someone else to do this.

There are ways to increase chance for someone working on it. All of them are either not too effective or require noticeable effort. Note that comments with complaints or +1 comments usually have an effect of making someone interested in fixing this less likely.

For people interested in just signalling interest in a fix there are often features allowing to note this, without sending notifications to all involved. Developers may look at open issues and may be more interested or motivated in fixing ones with multiple votes/

In GitHub it is called reactions allowing to add +1 without triggering notification send to every single person who enabled notifications in this issue or in repository in general (in this case - about 100 people).

See https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ for guide how you can add your +1 without sending flood of notifications.

1ec5 commented 3 years ago

788 added linking for architect:wikidata, artist:wikidata, brand:wikidata, operator:wikidata, and subject:wikidata. openstreetmap/openstreetmap-website@36a382bb43c81847b9463066a57cc7986d7cd731 added linking for name:etymology:wikidata and network:wikidata. #2812 would add linking for species:wikidata.

At a glance, it looks like this case:

https://github.com/openstreetmap/openstreetmap-website/blob/70d7d8d850148f714b70a3297c02a8203214dec6/app/helpers/browse_tags_helper.rb#L63-L64

needs to be consistent with this conditional:

https://github.com/openstreetmap/openstreetmap-website/blob/70d7d8d850148f714b70a3297c02a8203214dec6/app/helpers/browse_tags_helper.rb#L107-L108