search

openstreetmap / openstreetmap-website

The Rails application that powers OpenStreetMap
https://www.openstreetmap.org/
GNU General Public License v2.0
2.17k stars 913 forks source link

Vagrant and Docker installations are unmaintained #2344

Open tomhughes opened 5 years ago

tomhughes commented 5 years ago

Bother vagrant and docker installations suffer from constant bitrot where we add new dependencies or change configuration files but don't update the relevant setup scripts.

Unfortunately we have no way of detecting this until some unfortunate end user tries to use them because none of the main developers uses them.

We either need to find a way of testing them (is that even possible in travis? or is there some other way?) or we need to admit defeat and remove them.

tomhughes commented 5 years ago

So vagrant can't be done in travis apparently (https://github.com/travis-ci/travis-ci/issues/6060) so we can forget that at least.

openbrian commented 5 years ago

I'd prefer to develop in a docker environment. I can work on creating a new Dockerfile. Do you have any requirements? My plan is to create 2 images, one for db and one for rails. For me this may have to wait until after SotM US.

mmd-osm commented 5 years ago

@openbrian : see https://github.com/openstreetmap/openstreetmap-website/pull/2272

tomhughes commented 5 years ago

Yes this ticket is probably a bit confusing because I opened it thinking we already had a docker config but apparently my memory was faulty... Though it's definitely true that it would be good to have it tested to stop it breaking. That's something that I think travis can do, unlike vagrant.

gravitystorm commented 5 years ago

So I don't think we really need the vagrant/virtualbox bit tested, so much as the rest of the setup script i.e the contents of /script/vagrant/setup/provision.sh. Could that be tested on travis?

Of course, both the travis config and the vagrant setup (and the Docker setup) cover a lot of the same ground - installing postgres, bundle install, etc. So if there's a way to refactor things to share some code, that would be great too.

fazlerabbi37 commented 5 years ago

just find this page where is seems docker builds can be tested with travis. Though needs to take a closer look at this.

I'd prefer to develop in a docker environment. I can work on creating a new Dockerfile. Do you have any requirements? My plan is to create 2 images, one for db and one for rails. For me this may have to wait until after SotM US.

@openbrian please give your feedback on #2272 as I am just a novice on docker. :blush:

jalessio commented 4 years ago

For reference, just adding a note here that I'm attempting to address the Docker part of this in PR https://github.com/openstreetmap/openstreetmap-website/pull/2409