openstreetmap / openstreetmap-website

The Rails application that powers OpenStreetMap
https://www.openstreetmap.org/
GNU General Public License v2.0
2.2k stars 912 forks source link

Unlinked pagination showing up on Diary listing page #502

Closed KathleenLD closed 3 years ago

KathleenLD commented 11 years ago

When looking at a diary page with only a few posts (mine, for example) the "Older Entries | Newer Entries" text displays at the bottom of the page, but they aren't linked to anything. I would not have expected them to appear at all unless I had enough diary posts to necessitate another page, and even then I'd only expect the "Older Entries" option to display, unless I were already paging through them.

diary screenshot

I ran into this issue while using Chrome.

tomhughes commented 11 years ago

I'd say both behaviours are common on the web - sometime the next/previous link disappears at the end and sometimes it just becomes in active.

I don't see any pressing reason to change this, and would be reluctant to change this one without changing all the other places where we do similar paging.

KathleenLD commented 11 years ago

That's reasonable. It's certainly not a crisis. I just raised it because it looked like a bug to me when I saw it. Perhaps a style change down the line might help (graying out the options, rather than leaving the inactive links as standard text would make it clearer that they weren't left there by mistake)

tomhughes commented 11 years ago

Well we really need to cleanup all the various places where we do pagination to make then consistent...

seav commented 11 years ago

I think the reason why these texts are still there even if not active is that it makes the position of these texts consistent.

But, +1, on styling the inactive text to look inactive. I may also help if these look like buttons so that the inactive style looks more obvious.

gravitystorm commented 3 years ago

The links are now buttons, which "light up" when they are clickable and are grey when they are not.

Screenshot from 2021-03-24 15-23-56

Clickable version:

Screenshot from 2021-03-24 15-24-24

There's still room for improvement, but I think this original issue can be closed.