Update Copyright Page - Githubissues

mikelmaron commented 2 months ago

https://www.openstreetmap.org/copyright is the second most visited page on the website, but is not a great place to land and understand the project. It needs to present legal information, but should also explain the project well and direct people to get involved (https://www.openstreetmap.org/about does a decent job).

The CWG had developed recommendations on changes to content and presentation, and that text has been ok'd by the LWG and Board.

This now needs implementation. It reasonably straightforward. Requires some changes to layout in the view, updates/additions to the translation file, and perhaps facilitation of sufficient number of translations in the translation system.

Would be good to have guidance from maintainers if this is simple enough that it is sufficient to make this change in those text files and submit as a PR, or require someone to get the website running locally to test? Also, what is sufficient translation coverage for new strings in order to release an update?

And if someone wants to jump in and help with this small task would be much appreciated!

mikelmaron commented 2 months ago

Note there's a few other old issues which could possible be swept into these updates as well

gravitystorm commented 2 months ago

Also, what is sufficient translation coverage for new strings in order to release an update?

We make the changes to en.yml, the PR is merged, and then the translations come in at their own pace. We receive updates from translatewiki a few times per week. Deployments also happen every few days. But there's no coverage prerequisite on new or updated translation strings, so each deployment happens with whichever strings are available at that point, falling back to en.yml where necessary.

I've never looked to see what the average turnaround is between adding new strings (or updating existing ones) and how long until they are translated.

gravitystorm commented 2 months ago

The CWG had developed recommendations on changes to content and presentation, and that text has been ok'd by the LWG and Board.

This doesn't look finished to me, for example it has [Support paragraph with donate button] as the second paragraph.

Would be good to have guidance from maintainers if this is simple enough that it is sufficient to make this change in those text files and submit as a PR, or require someone to get the website running locally to test?

Sure, PRs are welcome. We do appreciate if the person making the PR also tests it locally, to make sure it works as intended. This reduces the burden on the reviewers.

tomhughes commented 2 months ago

Also while we know about the broken links we generally can't change them because they are part of third party mandated attributions - anything in the "our contributors" link is subject to agreement between LWG and upstream before we can accept changes.

tomhughes commented 2 months ago

I see that document also talks about a "sidebar" but I'm not sure that will be very consistent with the site design - it will depend on the details though.

simonpoole commented 2 months ago

We make the changes to en.yml, the PR is merged, and then the translations come in at their own pace.

It needs to be pointed out that changing the text in the source file (en.yml) does not invalidate existing translations for a specific string. That is OK if it is a button or whatever. but particularly in the case of legal/semi-legal texts that is typically not what you want.

simonpoole commented 2 months ago

Note there's a few other old issues which could possible be swept into these updates as well ...
* [Redesign /copyright to unify the wiki Contributors page #1878](https://github.com/openstreetmap/openstreetmap-website/issues/1878)

This needs a technical solution, it is definitely not done with the rewording of a couple of paragraphs.

PS: IMHO the reasonable solution would be to dump all attribution data in to a database and dynamically generate the attribution texts from that, this would lots of advantages, and some marginal downsides. See https://wiki.openstreetmap.org/wiki/Google_Summer_of_Code/2017/Project_Ideas#Third_Party_Source_Management_System

AntonKhorev commented 2 months ago

changing the text in the source file (en.yml) does not invalidate existing translations

If you want to force the text changes, you can rename the key, like this:

important_legal_text: something

to

important_legal_text_2024: something else

mmd-osm commented 2 months ago

To keep this issue actionable, I would suggest to skip the open points for the time being (that's: support paragraph with donate button, and the proposed new sidebar). The intro text has a comment "should be styled as a call out with a great visual". I would also skip this for now, due to lack of relevant details.

These points can be covered in another issue once we get some more details from CWG.

Also, I'd suggest to skip #1878 for now, since it's a project on its own, really. If you believe a 3rd party source management system is needed, #1878 might be a better place to discuss some high level requirements. Depending on the scope/estimated effort, EWG involvement might be needed.

mikelmaron commented 2 months ago

@mmd-osm agree keep it actionable. some of these open topics could be refined quickly, once we have momentum of implementation.

is there anyone willing and able to jump in an assist in implementation?

openstreetmap / openstreetmap-website

Update Copyright Page #5132