openstreetmap / openstreetmap-website

The Rails application that powers OpenStreetMap
https://www.openstreetmap.org/
GNU General Public License v2.0
2.17k stars 910 forks source link

Remove classic pagination #5205

Open AntonKhorev opened 2 weeks ago

AntonKhorev commented 2 weeks ago

This removes classic pagination library that's only used for changeset elements pagination:

tomhughes commented 2 weeks ago

Shouldn't we just be converting changesets to use the same pagination logic as everything else, rather than copying parts of classic pagination into the controller just so we can pretend we got rid of it?

AntonKhorev commented 1 week ago

Shouldn't we just be converting changesets to use the same pagination logic as everything else

That depends on how significant are the differences between changeset elements and everything else. The differences are: