Open AntonKhorev opened 2 weeks ago
Shouldn't we just be converting changesets to use the same pagination logic as everything else, rather than copying parts of classic pagination into the controller just so we can pretend we got rid of it?
Shouldn't we just be converting changesets to use the same pagination logic as everything else
That depends on how significant are the differences between changeset elements and everything else. The differences are:
offset
. But for changeset elements N can't get higher than 10000 / page size.
This removes classic pagination library that's only used for changeset elements pagination:
Paginator
class moved to controller'sElementsPaginator
PaginationHelper
module moved tosidebar_classic_pagination
helper