openstreetmap / openstreetmap-website

The Rails application that powers OpenStreetMap
https://www.openstreetmap.org/
GNU General Public License v2.0
2.22k stars 918 forks source link

Remove callback from initialize() in note js controller #5289

Closed AntonKhorev closed 1 month ago

AntonKhorev commented 1 month ago

https://github.com/openstreetmap/openstreetmap-website/commit/a796c41881c26e6da8828a71dbfb533613e5a83f added a callback to function initialize() in note.js. It's called at the very end of the function. Not scheduled in some event, not skipped by early termination, nothing runs after it. Passing a callback to initialize() is the same as running initialize(); callback();

tomhughes commented 1 month ago

Looks good to me, thanks.