Improvements to danger workflow

openstreetmap / openstreetmap-website

The Rails application that powers OpenStreetMap

https://www.openstreetmap.org/

GNU General Public License v2.0

2.21k stars 918 forks source link

Improvements to danger workflow #5290

Closed tomhughes closed 3 weeks ago

tomhughes commented 3 weeks ago

This gets the danger workflow working by switching to my fixed version (current open upstream as https://github.com/danger/danger/pull/1501) and also tweaks a few other things:

Renames the workflow to reflect that this is not just about labelling
Drops the run-name so that he runs will be names after the PR instead of all having the same name
Adjusts the label names to be consistent with our other labels.

mmd-osm commented 3 weeks ago

It seems you need to update the commit hash in Gemfile.lock. This works for me:

diff --git a/Gemfile.lock b/Gemfile.lock
index 346af2baa..d1bf08281 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -8,7 +8,7 @@ GIT

 GIT
   remote: https://github.com/tomhughes/danger.git
-  revision: 5794971ade2fb4239a346a4902700e0c6d4c04c7
+  revision: a265cf74d2f464a25796b48d95697f5eed553454
   ref: pull-request-target
   specs:

tomhughes commented 3 weeks ago

Ah sorry... I cherry picked and forgot I had updated the danger branch since. Now fixed.

mmd-osm commented 3 weeks ago

Looks good now. The danger failure is expected, you can't test any changes to Danger with a cross repo PR.

gravitystorm commented 3 weeks ago

Thanks for all your work getting to the bottom of this problem!