Open nenad-vujicic opened 2 days ago
Here are a few more benefits of adding note tags to OSM, as implemented by this PR:
Now we are ready for advanced filtering by specific tags (needs development)
Improves public outreach (by e.g. adding tags about mapathons)
@tyrasd @westnordost @Zverik @ToeBee @angoca @talllguy what do you think about this PR?
Thanks, Nenad.
Many of the use cases covered by this issue/PR are currently solved with hash tags (e.g. #surveyme) and tools are currently made to take these into account. Tools would need to be adapted to support tags as well. (Hashtags are not going away anytime soon)
The advantage of having tags implemented like this properly would be that there could be an efficient API with which to filter notes. (Right now, this is the only advantage I can think of over hash tags and stuff.) For example:
Description
PR adds support for note tags as described in #5294 Following changes are made:
note_tags
table, connected it with note table (using foreign key and associations), createdNoteTag
model file andNoteTagTest
class with basic tests (PR #5323 does this)browse/tag_details
partial, also, created test with multiple tags added rendering and checking if rendered HTML contains tagscreated_by, OpenStreetMaps-Website
for notes created using OSM website.Displayed resolved note:
Displayed opened note:
XML output for "opened note":
Displayed note without tags (all current):
Fixes #5294
How has this been tested?
Run tests from workflows, tested creating and displaying notes manually as administrator / moderator / regular user, tested displaying already existing notes (they will be displayed as earlier - without tags)