search

openstreetmap / openstreetmap-website

The Rails application that powers OpenStreetMap
https://www.openstreetmap.org/
GNU General Public License v2.0
2.08k stars 906 forks source link

OSRM implementation issues #902

Open systemed opened 9 years ago

systemed commented 9 years ago

Two problems with the OSRM routing script:

  1. We always request z=14. The heavily generalised polyline looks bad at higher zoom levels. We should either request the current zoom level, or choose a higher default.
  2. We always request instructions=true and refresh the LH directions panel, even when just dragging start/end points. This is flickery and inefficient. We should request instructions=false when dragging, instructions=true on dragend.

I might get round to these at some point but they're fairly trivial changes so treat this both as an aide-memoire and as a suggestion for anyone looking for quick wins. :)

tomhughes commented 9 years ago

I don't see how requesting the current zoom level makes any sense - as soon as the route comes in we will zoom to the bbox thus changing the zoom level! On top of which people will inevitably then zoom in to bits of the route to look at the details, which won't cause a recomputation.

Skippern commented 9 years ago

At roundabout takeout 2 in driving instructions, seems like it is missing spaces in the strings.