openstreetmap / osmdbt

OSM Database Replication Tools
GNU General Public License v3.0
24 stars 6 forks source link

Add github action deb builder #41

Open Firefishy opened 2 months ago

Firefishy commented 2 months ago

This builds debian packages for Ubuntu 22.04, Ubuntu 24.04 and Debian 12 (bookworm) and creates a draft GitHub release with the deb packages attached.

NOTE: This currently only works with tests disabled. See debian/rules

mmd-osm commented 2 months ago

Updated comment... it seems the osm-logical plugin in https://github.com/openstreetmap/osmdbt/tree/master/postgresql-plugin is not installed to run some of the unit tests...

  3: 2024-08-28 17:48:14.618 UTC [7967] postgres@postgres ERROR:  could not access file "osm-logical": No such file or directory
  3: 2024-08-28 17:48:14.618 UTC [7967] postgres@postgres STATEMENT:  SELECT * FROM pg_create_logical_replication_slot($1, 'osm-logical');
mmd-osm commented 2 months ago

@Firefishy : we didn't have much success when trying to run all test cases on Ubuntu Launchpad. After compiling the plugin, the build environment wouldn't let us copy osm-logical.so to the respective PostgreSQL directory, see https://github.com/openstreetmap/osmdbt/issues/13#issuecomment-658636021

Here's an old build log: https://launchpadlibrarian.net/610486627/buildlog_ubuntu-jammy-amd64.osmdbt_0.6-jammy1_BUILDING.txt.gz for https://launchpad.net/~mmd-osm/+archive/ubuntu/osmdbt-006/+packages

The package on Ubuntu Launchpad was built without unit tests...

Firefishy commented 2 months ago

The package on Ubuntu Launchpad was built without unit tests...

Same here, I disabled the tests in the same way as launchpad and build successfully completed.

joto commented 2 months ago

Okay for me. Disabling the test is not ideal but no worse than before.

mmd-osm commented 2 months ago

FYI: I was able to build packages with unit tests passing for the plugin free fork of the tool (see #38). That’s something to keep in mind, if we plan to do the transition at one point.