search

openstreetmap / osmtaginfo

Mediawiki extension for taginfo.openstreetmap.org
2 stars 2 forks source link

Excessive padding on taginfo iframe #1

Open ZeLonewolf opened 3 years ago

ZeLonewolf commented 3 years ago

The taginfo fragment loads into an iframe with extra space - 220px vs 190px which is actually needed. This adds 30px of extra whitespace on the right side of every taginfo block.

Could the iframe simply be made 30px narrower?

Alternately, could the PHP simply pull down the taginfo embed html and insert the contents directly rather than wrapping in an iframe? This would help resolve weird formatting issues that occur with an iframe wrapper.

Firefishy commented 3 years ago

PR welcome.

ZeLonewolf commented 3 years ago

How do I get repo permissions to post a PR?

Firefishy commented 2 years ago

@ZeLonewolf No special permission is required to create a Pull Request, fork the repo, create a branch, push branch and github gives you an option to create a pull request.

ZeLonewolf commented 2 years ago

Yep, I've figured out how to github since a year ago 😆

In the time since this issue was opened, I wrote, with some help from @1ec5, the taginfo2 template on the wiki, which uses a javascript/ajax approach instead of an iframe:

https://wiki.openstreetmap.org/wiki/Template:Taginfo2

The intent was for it to be a wholesale replacement for the taginfo template (and hopefully obviate the need for osmtaginfo). Though things seem to have stalled on that front. We had some discussion about keeping the iframe version as a fallback in case the user doesn't have javascript enabled (!) though that seems increasingly farfetched on the modern web.

Firefishy commented 2 years ago

@ZeLonewolf PR now open.